Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): escrow-v2-general-escrow-event-update #1396

Merged
merged 5 commits into from
Jan 10, 2024
Merged
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions contracts/src/arbitration/arbitrables/Escrow.sol
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,12 @@ contract Escrow is IArbitrableV2 {
/// @param _amount The initial amount in the transaction.
event TransactionCreated(
uint256 indexed _transactionID,
string _transactionUri,
address indexed _buyer,
address indexed _seller,
uint256 _amount
uint256 _amount,
string _asset,
uint256 _deadline
);

/// @dev To be emitted when a transaction is resolved, either by its
Expand Down Expand Up @@ -172,6 +175,7 @@ contract Escrow is IArbitrableV2 {
/// @return transactionID The index of the transaction.
function createTransaction(
uint256 _timeoutPayment,
string memory _transactionUri,
address payable _seller,
string memory _templateData,
string memory _templateDataMappings
Expand All @@ -186,7 +190,15 @@ contract Escrow is IArbitrableV2 {

transactionID = transactions.length - 1;

emit TransactionCreated(transactionID, msg.sender, _seller, msg.value);
emit TransactionCreated(
transactionID,
_transactionUri,
msg.sender,
_seller,
msg.value,
"native",
transaction.deadline
);
}

/// @dev Pay seller. To be called if the good or service is provided.
Expand Down