Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): mobile view top jurors and some refactors #1303

Merged
merged 6 commits into from
Oct 30, 2023
Merged

feat(web): mobile view top jurors and some refactors #1303

merged 6 commits into from
Oct 30, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Oct 25, 2023 •
edited by pr-codex bot
Loading

One thing to note is I created MobileCard.tsx and DesktopCard.tsx (because the components had different structures between desktop and mobile versions). Lmk what you think (we did the same with Navbar IIRC).

PR-Codex overview

This PR focuses on updating the TopJurors component in the Home page.

Detailed summary

  • Deleted JurorCard.tsx, TopJurorsHeader.tsx, and Rank.tsx.
  • Added Rank.tsx, JurorTitle.tsx, Coherency.tsx, HowItWorks.tsx, Rewards.tsx, and index.tsx.
  • Updated WithHelpTooltip.tsx.
  • Updated JurorCard/index.tsx.
  • Updated TopJurors/index.tsx.
  • Updated JurorCard/Rank.tsx.
  • Updated JurorCard/JurorTitle.tsx.
  • Updated Header/HowItWorks.tsx.
  • Updated JurorCard/HowItWorks.tsx.
  • Updated Header/Rewards.tsx.
  • Updated Header/Coherency.tsx.
  • Updated Header/index.tsx.
  • Updated JurorCard/Rewards.tsx.

The following files were skipped due to too many changes: web/src/pages/Home/TopJurors/JurorCard/Rewards.tsx, web/src/pages/Home/TopJurors/JurorCard/DesktopCard.tsx, web/src/pages/Home/TopJurors/JurorCard/MobileCard.tsx, web/src/assets/svgs/menu-icons/help.svg

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit d4f554b
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65400481a2728900083917c0
😎 Deploy Preview https://deploy-preview-1303--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru changed the title refactor(web): top jurors components modularization feat(web): mobile view top jurors and some refactors Oct 25, 2023
@kemuru kemuru marked this pull request as ready for review October 25, 2023 23:28
@kemuru kemuru requested review from alcercu and jaybuidl October 25, 2023 23:28
@kemuru kemuru linked an issue Oct 25, 2023 that may be closed by this pull request
Top Jurors: mobile layout #1300
Closed
@kemuru kemuru added Type: Enhancement ✨ Package: Web Court web frontend Type: UX User Experience labels Oct 25, 2023
alcercu
alcercu requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve rest of comments

@jaybuidl jaybuidl added this to the testnet-2.1 milestone Oct 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit d4f554b and detected 15 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2
Style 13

View more on Code Climate.

@jaybuidl jaybuidl enabled auto-merge October 30, 2023 19:41
@jaybuidl jaybuidl merged commit d4f554b into dev Oct 30, 2023
11 checks passed
@jaybuidl jaybuidl deleted the feat(web)/mobile-view-top-jurors-and-some-refactors branch October 30, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu requested changes

@jaybuidl jaybuidl jaybuidl approved these changes

Assignees
No one assigned
Labels
Package: Web Court web frontend Type: Enhancement ✨ Type: UX User Experience
Projects
None yet
Milestone
testnet-2.1
Development

Successfully merging this pull request may close these issues.

Top Jurors: mobile layout
3 participants
@kemuru @jaybuidl @alcercu