Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgradability improvements and bumped hardhat-deploy #1274

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Oct 13, 2023

image


PR-Codex overview

Focus:

This PR focuses on upgrading the deployment scripts and making changes to various contracts related to proxies and upgradability.

Detailed summary:

  • Upgraded the deployment scripts to use deployments instead of hre for deployment.
  • Updated the deployUpgradable function calls to use deployments instead of hre.
  • Updated the contract imports in various files.
  • Updated the version of hardhat-deploy to 0.11.42 in the package.json file.
  • Added the Initializable contract import to the Constants.sol file.
  • Updated the SPDX license identifier in the UpgradedByRewrite.sol and UpgradedByRewriteV2.sol files.
  • Made changes to the UpgradedByRewrite.sol and UpgradedByRewriteV2.sol contracts related to the implementation and state variables.
  • Added the IERC20 contract import to the Constants.sol file.
  • Made changes to the UpgradedByInheritanceV1.sol and UpgradedByInheritanceV2.sol contracts related to the implementation and state variables.
  • Updated the hardhat-deploy version in the yarn.lock file.

The following files were skipped due to too many changes: contracts/src/proxy/mock/by-inheritance/UpgradedByInheritance.sol, contracts/src/gateway/ForeignGateway.sol, contracts/deploy/00-home-chain-arbitration.ts, contracts/src/gateway/HomeGateway.sol, contracts/deploy/utils/deployUpgradable.ts, contracts/src/arbitration/KlerosCore.sol, contracts/test/proxy/index.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@jaybuidl jaybuidl self-assigned this Oct 13, 2023
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 51ef929
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/652dbdd24af2210008907f27
😎 Deploy Preview https://deploy-preview-1274--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@codeclimate
Copy link

codeclimate bot commented Oct 16, 2023

Code Climate has analyzed commit 51ef929 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.

@jaybuidl jaybuidl merged commit 51ef929 into dev Oct 16, 2023
7 of 11 checks passed
@jaybuidl jaybuidl deleted the fix/upgradability branch October 16, 2023 22:56
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant