Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): feedback by plinio implementation #1253

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Oct 4, 2023

addressed the points that were missing (2, 6 and 10) from this feedback compilation:

Screenshot from 2023-10-04 18-16-18
Screenshot from 2023-10-04 18-16-12
Screenshot from 2023-10-04 18-15-45
Screenshot from 2023-10-04 18-16-02


PR-Codex overview

This PR focuses on improving the layout and styling of various components in the web application.

Detailed summary

  • Updated font family and size for textarea element in global styles.
  • Adjusted width and max-width for Menu/Help.tsx component.
  • Modified grid-template-columns for Stats.tsx component.
  • Updated padding, max-width, and margin for Home/index.tsx, Cases/index.tsx, Courts/index.tsx, and Dashboard/index.tsx components.
  • Adjusted width for Popup/index.tsx component.
  • Modified width and max-height for DappList.tsx component.
  • Adjusted width, max-width, and padding for Settings/index.tsx component.
  • Updated import and usage of StyledSkeleton component in LatestCases.tsx.
  • Added new styled components for skeleton cards in StyledSkeleton.tsx.
  • Updated import and usage of skeleton components in CasesGrid.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 70b1de5
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65257489a154a700082a6e59
😎 Deploy Preview https://deploy-preview-1253--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Oct 10, 2023

Code Climate has analyzed commit 70b1de5 and detected 112 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 37
Style 73

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu enabled auto-merge October 10, 2023 16:01
@alcercu alcercu added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 10, 2023
@alcercu alcercu added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 10, 2023
@jaybuidl jaybuidl added this pull request to the merge queue Oct 11, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Oct 11, 2023
@jaybuidl jaybuidl merged commit 70b1de5 into dev Oct 11, 2023
11 checks passed
@jaybuidl jaybuidl deleted the fix(web)/styling-feedback-plinio branch October 11, 2023 10:14
@jaybuidl jaybuidl added Package: Web Court web frontend Type: UX User Experience labels Oct 11, 2023
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Web Court web frontend Type: UX User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants