feat(web): cases-grid-and-list-display #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jaybuidl
added
Type: Enhancement ✨
Package: Web
jaybuidl
requested changes
Sep 11, 2023
There was a problem hiding this comment.
I found a few issues:
- In mobile format, the list view exceeds the screen width. Either we try to support horizontal scrolling (probably too much work), either we disable the list view button until the screen is wide enough.
- There is an intermediate width (at 00:12s in the video) where the last columns headers wrap to the next line
- In desktop view, some disputes info is not aligned (court, reward, deadline) and the category is missing when the title is somewhat long (at 00:25s in the video)
screen.mov
|
Code Climate has analyzed commit d233f69 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
alcercu
requested changes
Sep 14, 2023
There was a problem hiding this comment.
- There is horizontal scrolling on mobile on the cases page, one approach to fixing this would be to fix the width to 312px on mobile, and 380px on landscape.
- When using the list view, if the title of the dispute is too big, it looks bad, we either decide to show only two lines and then "..." or we allow them to expand vertically 🤔 I am inclined towards the first option.
- For the grid <> list switch, if we use grey it looks like it's disabled 🤔 I would either show both in blue with the selected one with some kind of highlight, like glow, or show only the one you can change towards (i.e. if we are on grid view, only show the icon to change to list view, and viceversa)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #688 , also fixes Dashboard page cases section