Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting of the PNK balance, stake and amount in input field #1212

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Formatting of the PNK balance, stake and amount in input field #1212

merged 2 commits into from
Sep 4, 2023

Conversation

jaybuidl
Copy link
Member

@jaybuidl jaybuidl commented Sep 2, 2023 •
edited
Loading

Before After
image image

@netlify
Copy link

netlify bot commented Sep 2, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 18766cd
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/64f57a3f861d5c00087c282b
😎 Deploy Preview https://deploy-preview-1212--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaybuidl jaybuidl added Type: Enhancement ✨ Package: Web Court web frontend Type: UX User Experience labels Sep 2, 2023
@jaybuidl jaybuidl self-assigned this Sep 2, 2023
@jaybuidl jaybuidl requested review from alcercu and kemuru September 2, 2023 16:47
@jaybuidl jaybuidl marked this pull request as ready for review September 2, 2023 16:48
@jaybuidl jaybuidl force-pushed the feat/staking-input-field-format branch from 3972883 to f7618d0 Compare September 2, 2023 16:55
kemuru
kemuru approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codeclimate
Copy link

codeclimate bot commented Sep 2, 2023

Code Climate has analyzed commit 841b570 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl force-pushed the feat/staking-input-field-format branch from 841b570 to 18766cd Compare September 4, 2023 06:33
@jaybuidl jaybuidl merged commit 18766cd into dev Sep 4, 2023
5 of 9 checks passed
@jaybuidl jaybuidl deleted the feat/staking-input-field-format branch September 4, 2023 06:33
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemuru kemuru kemuru approved these changes

@alcercu alcercu Awaiting requested review from alcercu

Assignees

@jaybuidl jaybuidl

Labels
Package: Web Court web frontend Type: Enhancement ✨ Type: UX User Experience
Projects
None yet
Milestone
testnet-2
Development

Successfully merging this pull request may close these issues.
2 participants
@jaybuidl @kemuru