Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): desktop responsiveness navbar, footer, community section, dashboard juror info, home page.. #1211

Merged
merged 29 commits into from
Sep 18, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Sep 2, 2023

this PR contains Desktop responsiveness for: Navbar, Footer, Community Section, Dashboard's Juror Info, Home page, etc

@netlify
Copy link

netlify bot commented Sep 2, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 0a7e5ce
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/65006be9d66f010008f82bdc
😎 Deploy Preview https://deploy-preview-1211--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemuru kemuru added Type: Enhancement ✨ Package: Web Court web frontend Type: UX User Experience labels Sep 2, 2023
@kemuru kemuru changed the title feat(web): navbar and footer for desktop feat(web): desktop responsiveness navbar, footer, community section Sep 2, 2023
@kemuru kemuru changed the title feat(web): desktop responsiveness navbar, footer, community section feat(web): desktop responsiveness navbar, footer, community section, dashboard juror info Sep 4, 2023
@kemuru kemuru changed the title feat(web): desktop responsiveness navbar, footer, community section, dashboard juror info feat(web): desktop responsiveness navbar, footer, community section, dashboard juror info, home page.. Sep 4, 2023
@jaybuidl jaybuidl requested a review from alcercu September 11, 2023 05:25
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to maintain the mobile first philosophy, as I mentioned on the smallScreenStyle comment, the changes would require to take what's inside the smallScreenStyle function, move it outside, and then use a landscapeStyle to style for bigger screens.
I know that a lot of work has gone into this, so I won't push this too much, if your call is to go with this PR @kemuru @nhestrompia @jaybuidl I'm okay with it

web/src/styles/tabletScreenStyle.ts Outdated Show resolved Hide resolved
web/src/styles/smallScreenStyle.ts Outdated Show resolved Hide resolved
web/src/layout/Header/navbar/Explore.tsx Outdated Show resolved Hide resolved
web/src/pages/Home/Header.tsx Outdated Show resolved Hide resolved
@kemuru
Copy link
Contributor Author

kemuru commented Sep 11, 2023

I would like to maintain the mobile first philosophy, as I mentioned on the smallScreenStyle comment, the changes would require to take what's inside the smallScreenStyle function, move it outside, and then use a landscapeStyle to style for bigger screens. I know that a lot of work has gone into this, so I won't push this too much, if your call is to go with this PR @kemuru @nhestrompia @jaybuidl I'm okay with it

yeah I think that makes sense too. I can invert the queries today maybe. Which landscapeStyle breakpoint should we use?

@alcercu
Copy link
Contributor

alcercu commented Sep 11, 2023

I would like to maintain the mobile first philosophy, as I mentioned on the smallScreenStyle comment, the changes would require to take what's inside the smallScreenStyle function, move it outside, and then use a landscapeStyle to style for bigger screens. I know that a lot of work has gone into this, so I won't push this too much, if your call is to go with this PR @kemuru @nhestrompia @jaybuidl I'm okay with it

yeah I think that makes sense too. I can invert the queries today maybe. Which landscapeStyle breakpoint should we use?

Depends on what we want for tablet 🤔 If we want landscape tablet to be like desktop, I would go with 900px. If we want it to look like mobile, I would go with 1200px. (I incline towards 900px, so tablet portrait would look like mobile and tablet landscape would look like desktop)

@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit 0a7e5ce and detected 16 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 14

View more on Code Climate.

@alcercu alcercu changed the base branch from dev to web-staging September 13, 2023 09:44
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu merged commit 0dd543c into web-staging Sep 18, 2023
5 checks passed
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
@jaybuidl jaybuidl deleted the feat(web)/desktop-navbar-and-responsiveness branch January 3, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Web Court web frontend Type: Enhancement ✨ Type: UX User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants