-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): desktop responsiveness navbar, footer, community section, dashboard juror info, home page.. #1211
feat(web): desktop responsiveness navbar, footer, community section, dashboard juror info, home page.. #1211
Conversation
✅ Deploy Preview for kleros-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to maintain the mobile first philosophy, as I mentioned on the smallScreenStyle
comment, the changes would require to take what's inside the smallScreenStyle
function, move it outside, and then use a landscapeStyle
to style for bigger screens.
I know that a lot of work has gone into this, so I won't push this too much, if your call is to go with this PR @kemuru @nhestrompia @jaybuidl I'm okay with it
yeah I think that makes sense too. I can invert the queries today maybe. Which landscapeStyle breakpoint should we use? |
Depends on what we want for tablet 🤔 If we want landscape tablet to be like desktop, I would go with 900px. If we want it to look like mobile, I would go with 1200px. (I incline towards 900px, so tablet portrait would look like mobile and tablet landscape would look like desktop) |
…com:kleros/kleros-v2 into feat(web)/desktop-navbar-and-responsiveness
Code Climate has analyzed commit 0a7e5ce and detected 16 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
this PR contains Desktop responsiveness for: Navbar, Footer, Community Section, Dashboard's Juror Info, Home page, etc