Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): vote-stake-data #1200

Merged
merged 4 commits into from
Sep 13, 2023
Merged

fix(web): vote-stake-data #1200

merged 4 commits into from
Sep 13, 2023

Conversation

nhestrompia
Copy link
Contributor

fixes #1196

@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit 7e3dc94
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6501803303bfc10008d99376
😎 Deploy Preview https://deploy-preview-1200--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 4bbf258
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64ec7183cf916300077b025d
😎 Deploy Preview https://deploy-preview-1200--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alcercu
alcercu requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct formula for the vote stake is (minStake * alpha) / 1e4
image

@codeclimate
Copy link

codeclimate bot commented Sep 13, 2023

Code Climate has analyzed commit 7e3dc94 and detected 0 issues on this pull request.

View more on Code Climate.

@alcercu alcercu changed the base branch from dev to web-staging September 13, 2023 09:44
alcercu
alcercu approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alcercu alcercu merged commit 88cb3ca into web-staging Sep 13, 2023
5 checks passed
@alcercu alcercu deleted the fix(web)/vote-stake-data branch September 13, 2023 09:47
@kemuru kemuru mentioned this pull request Oct 4, 2023
Closed
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees
No one assigned
Labels
Type: Bug 🐛
Projects
None yet
Milestone
testnet-2
Development

Successfully merging this pull request may close these issues.

Court stats: same data for Min Stake and Vote Stake seems incorrect
3 participants
@nhestrompia @alcercu @jaybuidl