Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): disable appeal tab on last round and add info message #1184

Merged
merged 3 commits into from
Sep 18, 2023
Merged

feat(web): disable appeal tab on last round and add info message #1184

merged 3 commits into from
Sep 18, 2023

Conversation

kemuru
Copy link
Contributor

@kemuru kemuru commented Aug 23, 2023

closes #1183

@netlify
Copy link

netlify bot commented Aug 23, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit b91ec3a
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/64fea9bb16c8790008aa782b
😎 Deploy Preview https://deploy-preview-1184--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 23, 2023 •
edited
Loading

✅ Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 509a3ea
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64e918e037015100098b46c3
😎 Deploy Preview https://deploy-preview-1184--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jaybuidl jaybuidl added Type: Enhancement ✨ Package: Web Court web frontend Type: UX User Experience labels Sep 11, 2023
@jaybuidl jaybuidl force-pushed the fix(web)/disable-appeal-tab-on-last-round branch from 509a3ea to b91ec3a Compare September 11, 2023 05:46
@codeclimate
Copy link

codeclimate bot commented Sep 11, 2023

Code Climate has analyzed commit b91ec3a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

alcercu
alcercu approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alcercu alcercu changed the base branch from dev to web-staging September 13, 2023 09:45
@alcercu alcercu merged commit 464fd49 into web-staging Sep 18, 2023
3 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl deleted the fix(web)/disable-appeal-tab-on-last-round branch September 26, 2023 13:06
@kemuru kemuru mentioned this pull request Oct 4, 2023
Closed
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcercu alcercu alcercu approved these changes

Assignees

@kemuru kemuru

Labels
Package: Web Court web frontend Type: Enhancement ✨ Type: UX User Experience
Projects
None yet
Milestone
testnet-2
Development

Successfully merging this pull request may close these issues.

Web: let the user know the dispute is on last round...
4 participants
@kemuru @alcercu @jaybuidl @nhestrompia