Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): cases filtering #1169

Merged
merged 39 commits into from
Oct 7, 2023
Merged

Feat(web): cases filtering #1169

merged 39 commits into from
Oct 7, 2023

Conversation

alcercu
Copy link
Contributor

@alcercu alcercu commented Aug 18, 2023

Closes #689 #690 #1176

PR-Codex overview

This PR focuses on adding new features and making improvements to the codebase.

Detailed summary:

  • Added new fields and properties to various entities
  • Updated styles and themes
  • Modified page layouts and components
  • Refactored queries and hooks
  • Fixed bugs and improved user experience

The following files were skipped due to too many changes: web/src/components/CasesDisplay/Stats.tsx, web/src/app.tsx, web/src/pages/Courts/TopSearch.tsx, subgraph/src/entities/Dispute.ts, web/src/pages/Home/LatestCases.tsx, subgraph/schema.graphql, web/src/pages/Cases/CaseDetails/Overview.tsx, subgraph/src/entities/Round.ts, web/src/pages/Cases/index.tsx, web/src/hooks/queries/useUser.ts, web/src/components/DisputeCard/index.tsx, web/src/components/DisputeCard/DisputeInfo.tsx, web/src/pages/Dashboard/index.tsx, web/src/components/CasesDisplay/Search.tsx, web/src/pages/Cases/CasesFetcher.tsx, web/src/hooks/queries/useCasesQuery.ts, web/src/components/CasesDisplay/CasesGrid.tsx, web/src/components/CasesDisplay/Filters.tsx, subgraph/src/KlerosCore.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for kleros-v2-contracts ready!

Name Link
🔨 Latest commit 4bed1b3
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-contracts/deploys/64ec899d5c78cd0008404325
😎 Deploy Preview https://deploy-preview-1169--kleros-v2-contracts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit f42cc14
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/6520a439e3a026000808e04d
😎 Deploy Preview https://deploy-preview-1169--kleros-v2.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alcercu alcercu added this pull request to the merge queue Aug 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@jaybuidl
Copy link
Member

"My Cases" shows some cards loading forever for a user who has never staked.

Once staked or even unstaked, it's fine. It must be related to #1176
image

This was linked to issues Aug 22, 2023
@kemuru kemuru linked an issue Aug 28, 2023 that may be closed by this pull request
@codeclimate
Copy link

codeclimate bot commented Sep 12, 2023

Code Climate has analyzed commit bfe027c and detected 15 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 7
Style 8

View more on Code Climate.

@alcercu alcercu changed the base branch from dev to web-staging September 13, 2023 09:43
@jaybuidl jaybuidl marked this pull request as draft September 20, 2023 10:31
Base automatically changed from web-staging to dev September 25, 2023 15:08
@alcercu alcercu marked this pull request as ready for review October 5, 2023 14:36
@kemuru kemuru self-requested a review October 6, 2023 07:37
Copy link
Contributor

@kemuru kemuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one problem regarding the number of pages after filtering for periods, sometimes it's not recalculated (video below). otherwise, the rest looks good.

2023-10-06.09-39-30.mp4

jaybuidl
jaybuidl previously approved these changes Oct 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jaybuidl jaybuidl removed a link to an issue Oct 7, 2023
@jaybuidl jaybuidl merged commit f42cc14 into dev Oct 7, 2023
10 of 11 checks passed
@jaybuidl jaybuidl deleted the feat(web)/cases-filtering branch October 7, 2023 00:26
@jaybuidl jaybuidl added this to the testnet-2 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants