Handle implied padding in composite types and at end of blocks #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some code to handle implied padding, but it didn't quite go far enough for some functions.
The first type of padding is between composite type components, as indicated by the
offset
attribute of said components.The second is padding at the end of blocks to make the total length equal to the stated
blockLength
This happens for message fields (groups do not count towards the messageblockLength
) and group fields.