Faster DOM rendering when processing toolbar filters #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by collecting a list of DOM selectors to be queried/shown via jQuery multiple-selector at the same time instead of calling .show() for each one of them. For 1-2 rows this is on-par with the previous implementation, however it is around 2x faster when the result set contains many rows (say 100 or 1000). WARNING: when a result set contains hundreds of rows there is still a noticeable lag on the page. For example if filtering 1000 rows for is_automated=false, where only 10 rows have the value of True and the rest 990 have the value of False! See https://api.jquery.com/multiple-selector/
building upon the previous change we now either show or hide rows on screen depending on what the actual result set is. When the rows which match the filter are less than the ones which don't we display only them. Else we display everything and hide the rows which don't match the filter. This always results in the minimum number of display updates. For the extreme scenario where 990/1000 rows match is_automated=false this provides 30x improvement! WARNING: for scenarios which are not on the extreme case, yet still result in 100s of rows that need to be displayed this commit does not offer any optimization compared to the previous one!
atodorov
force-pushed
the
faster_dom_rendering_for_filters
branch
from
7b7bf96
to
7d31a59
Compare
will be used for filtering TestExecutions in the next commit!
NOTE: use a different underlying API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.