Update filter logic for Automated=False. Fixes #3841 #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the boolean expression tc[filterBy] was intended to check whether the requested field exists, as a way to avoid crashes in the case where we may have forgotten to update the code. However in the case when trying to search for manual test cases the raw value of this field is `false` which caused the entire expression to be evaulated as False and did not apply the filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the boolean expression tc[filterBy] was intended to check whether the requested field exists, as a way to avoid crashes in the case where we may have forgotten to update the code. However in the case when trying to search for manual test cases the raw value of this field is
falsewhich caused the entire expression to be evaulated as False and did not apply the filter.