Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade itsdangerous recipe to 2.2.0 #946

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hemna
Copy link

@hemna hemna commented Nov 18, 2024

itsdangerous version 2.2.0 eliminated their setup.py, so all toolchain builds of itsdangerous fails due to missing setup.py.

This patch updates the recipe for itsdangerous to run pip to install the 2.2.0 version.

itsdangerous version 2.2.0 eliminated their setup.py, so all
toolchain builds of itsdangerous fails due to missing setup.py.

This patch updates the recipe for itsdangerous to run pip to
install the 2.2.0 version.
@AndreMiras
Copy link
Member

Thanks for picking this up @hemna
This looks good to me and CI seems happy.
Did you get a chance to test it in runtime and confirm it's working?

@hemna
Copy link
Author

hemna commented Nov 19, 2024

I haven't been able to test yet, because I can't get a successful build for ios yet.

@AndreMiras
Copy link
Member

I haven't been able to test yet, because I can't get a successful build for ios yet.

Why not? You can use your fork directly to build your app

@Novfensec Novfensec mentioned this pull request Nov 22, 2024
@hemna
Copy link
Author

hemna commented Nov 22, 2024

I'm having a problem with getting a build to work at all.

The kivy-ios documentation says to install cython==3.0.0, but that gives this error.
#944

I tried to build after that error and I get a failure building ios.pyx

[DEBUG   ] Installed /Users/I530566/devel/mine/hamradio/kivy/AprsChat/.buildozer/ios/platform/kivy-ios/dist/root/python3/lib/python3.11/site-packages/click-8.1.7-py3.11.egg
[DEBUG   ] Processing dependencies for click==8.1.7
[DEBUG   ] Finished processing dependencies for click==8.1.7
[DEBUG   ] New State: click.build_all at 2024-11-22 14:28:29.166142
[INFO    ] Download ios
[DEBUG   ] New State: ios.download at 2024-11-22 14:28:29.172405
[INFO    ] Extract ios
[INFO    ] Extract ios for iphoneos-arm64
[INFO    ] Extract ios for iphonesimulator-arm64
[DEBUG   ] New State: ios.extract at 2024-11-22 14:28:29.197089
[INFO    ] Install_hostpython_prerequisites ios
[DEBUG   ] New State: ios.install_hostpython_prerequisites at 2024-11-22 14:28:29.200586
[INFO    ] Build_all ios
[INFO    ] Build ios for iphoneos-arm64, iphonesimulator-arm64 (filtered)
[INFO    ] Build ios
[INFO    ] Prebuild ios for arm64
[DEBUG   ] Invoking prebuild_arm64
[INFO    ] Build ios for arm64
[INFO    ] Cythonize ios.pyx
[INFO    ] Running Shell: /Users/I530566/devel/mine/hamradio/kivy/.venv/bin/python ('/Users/I530566/devel/mine/hamradio/kivy/AprsChat/.buildozer/ios/platform/kivy-ios/kivy_ios/tools/cythonize.py', 'ios.pyx') {'_iter': True, '_out_bufsize': 1, '_err_to_out': True}
[DEBUG   ] -- cythonize ['/Users/I530566/devel/mine/hamradio/kivy/AprsChat/.buildozer/ios/platform/kivy-ios/kivy_ios/tools/cythonize.py', 'ios.pyx']
[DEBUG   ] cythonize: ios.pyx
[DEBUG   ] /Users/I530566/devel/mine/hamradio/kivy/.venv/lib/python3.12/site-packages/Cython/Compiler/Main.py:381: FutureWarning: Cython directive 'language_level' not set, using '3str' for now (Py3). This has changed from earlier releases! File: /Users/I530566/devel/mine/hamradio/kivy/AprsChat/.buildozer/ios/platform/kivy-ios/build/ios/iphoneos-arm64/src/ios.pyx
[DEBUG   ]   tree = Parsing.p_module(s, pxd, full_module_name)
[DEBUG   ]
[DEBUG   ] Error compiling Cython file:
[DEBUG   ] ------------------------------------------------------------
[DEBUG   ] ...
[DEBUG   ]
[DEBUG   ]
[DEBUG   ]     Py_INCREF(callback)
[DEBUG   ]
[DEBUG   ]     ret = ios_send_email(j_subject, j_text, j_mimetype, j_filename,
[DEBUG   ]             j_filename_alias, _send_email_done, <void *>callback)
[DEBUG   ]                               ^
[DEBUG   ] ------------------------------------------------------------
[DEBUG   ]
[DEBUG   ] ios.pyx:195:30: Cannot assign type 'void (char *, void *) except *' to 'ios_send_email_cb' (alias of 'void (*)(char *, void *) noexcept'). Exception values are incompatible. Suggest adding 'noexcept' to the type of '_send_email_done'.
[DEBUG   ] no need to rewrite ios.pyx

@Novfensec Novfensec mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants