Remove some attributes defined outside of __init__() #1694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes of a class instance should, where possible, be defined in the
__init__()
method, for clarity (especially about lifetimes). Pylint has a warning about this, but I can't see one from Flake8.TargetAndroid has an attribute
_serials
which is defined (sometimes) outside of__init()__
, and its value is checked withhasattr()
. Changed it to act like a normal instance attribute, defined in__init__()
.Buildozer() goes even further. It monkey-patches two attributes,
_build_prepared
and_build_done
onto its associated target. These attributes have the same lifetime as the Buildozer instance. I removed the monkey-patching, and made them normal instance attributes of Buildozer, defined in__init__()
.