Clean up inheritance of targets #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Target class contained Android-only attribute "artifact_format". Moved that code into TargetAndroid class. 2) TargetIos had a `check_build_prepared()` method that was ineffective. `prepare_for_build()` sets `target._build_prepared` to True. Then `check_build_prepared()` inexplicably set it to False. Then `build()` checks for its existence, rather than its value [this is code smell that is on my list for later], so the fact that it had been changed made no difference. So, I removed the method, and the call to it. 2) TargetOSX had lots of methods that were identical to its base class implementations (three more, once the above steps were done). They don't need to be specified; they are inherited. I removed them. `osx.py` is now 20% smaller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target class contained Android-only attribute "artifact_format". Moved that code into TargetAndroid class.
TargetIos had a
check_build_prepared()method that was ineffective.prepare_for_build()setstarget._build_preparedto True. Thencheck_build_prepared()inexplicably set it to False. Thenbuild()checks for its existence, rather than its value [this is code smell that is on my list for later], so the fact that it had been changed made no difference.So, I removed the method, and the call to it.
osx.pyis now 20% smaller.