Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to latest versions #1680

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Sep 6, 2023

In the various YAML files, the Github actions are locked to particular versions.

Some actions are out of date and are causing deprecation annotations. e.g.:

pypi_release
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

This PR updates all of the actions to the latest.

I briefly looked for any changes that affected this CI, but I didn't find any, which was as expected.

Getting deprecation warnings, so time to upgrade.
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment regarding actions/setup-python version. Let me know what are your thoughts.

- name: Set up Python 3.x
uses: actions/setup-python@v2
uses: actions/setup-python@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use actions/setup-python@v4 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My best guess: When I looked up the latest version number, and noted it down wrong, I wasn't wearing my glasses or the sun was in my eyes or I was drunk. :-( Sorry.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit 7dbfeae into kivy:master Sep 10, 2023
14 of 15 checks passed
@Julian-O Julian-O deleted the Checkoutv4 branch September 10, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants