Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garden fix - kivy_garden package isn't a thing #43

Closed
wants to merge 7 commits into from
Closed

Garden fix - kivy_garden package isn't a thing #43

wants to merge 7 commits into from

Conversation

Cheaterman
Copy link
Contributor

Everything in the title - kivy.garden.zbarcam works here, kivy_garden.zbarcam doesn't. Possibly the issue is on my end, but AIUI, kivy_garden isn't a thing?

This PR is rebased onto #39 and #42 - if that's an issue I'll split everything up.

Thanks in advance :-)

@Cheaterman
Make QRcode decoding non-blocking by doing it in a thread
464113f
@Cheaterman
Fix _detect_qrcode_frame signature in tests
96a0aea 
It takes pixels independently of texture because in normal usage the
decoding will be done in a separate thread (which therefore can't make
the required GL calls to access the pixels).
@Cheaterman
Set _decoding_frame and _symbols_queue in __init__ for unit tests
a295964
@Cheaterman
Rewrite threading to make it test-friendly
0b7d7df
@Cheaterman
Make isort happy as well.
5669e5a
@Cheaterman
Use zbarlight as alternative to pyzbar when it's not available
3fd7463 
TODO: Fix setup.py install/extra_requires accordingly, as well as
requirements in buildozer.spec for demo app
@Cheaterman
Fix garden compatibility
be33cbb
@AndreMiras
Copy link
Collaborator

I'm not sure I understand how this is happening as yes kivy_garden should be a thing and kivy.garden is not. Actually kivy.garden got deprecated some time ago, see #17

@Cheaterman
Copy link
Contributor Author

Whoa @AndreMiras thanks a lot for the information! My incorrect inference was made when using garden install --app zbarcam to package the flower on Android/iOS, and it didn't seem to work with kivy_garden but did with kivy.garden... I'll look into all of this for more info, and possibly make a PR on Kivy if that's the issue. Thanks again, sorry for the noise!

@AndreMiras
Copy link
Collaborator

Ah yes I see, yes indeed we dropped garden command, now you simply pip install zbarcam on desktop since it's available on PyPI https://pypi.org/project/zbarcam/
And on Android as well it will be a normal pip dependency, no longer under the garden in buildozer

@Cheaterman
Copy link
Contributor Author

Ah alright, I didn't know that was a thing! Thanks a lot for the info, I'll do as you suggested and see what happens :-)

@Cheaterman Cheaterman closed this Oct 28, 2020
@Cheaterman Cheaterman deleted the garden_fix branch October 28, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cheaterman @AndreMiras