Prevent duplicate and invalid titles #6326
Conversation
BartChris
force-pushed
the
fix_duplicate_titles
branch
2 times, most recently
from
e8c63dd
to
f23289c
Compare
| @@ -367,7 +367,7 @@ public enum ParameterCore implements ParameterInterface { | |||
| /** | |||
| * Validation of process title via regular expression. | |||
| */ | |||
| VALIDATE_PROCESS_TITLE_REGEX(new Parameter<>("validateProzessTitelRegex", "[\\w-]*")), | |||
| VALIDATE_PROCESS_TITLE_REGEX(new Parameter<>("validateProzessTitelRegex", "^[a-zA-Z0-9_-]+$")), | |||
There was a problem hiding this comment.
Should the new default value not even updated in the kitodo_config.properties files?
There was a problem hiding this comment.
I am wondering: This is a hard limitation of the Kitodo software, some titles lead to problems later. Should we allow to change that in the config.properties at all? Or should we hardcode that in the application? Additionally one can think of allowing additional regexes which might be checked on top of the minimal requirements. See #6055
cc @solth
There was a problem hiding this comment.
At SLUB we allow even the . inside the process title as for historical reasons this was needed to create the processes. Maybe this can be changed now but this should be discussed.
There was a problem hiding this comment.
One more note: the w meta character in regular expressions stands for a-z, A-Z, 0-9, including _ (underscore) . So the expression can be simplified to ^[\\w-]+$?
There was a problem hiding this comment.
What about chosing a new parameter name "validateProcessTitle" which avoids the current "denglisch" (English-German mix)?
Kitodo/src/main/java/org/kitodo/production/forms/createprocess/CreateProcessForm.java
Outdated
Show resolved
Hide resolved
BartChris
force-pushed
the
fix_duplicate_titles
branch
from
f23289c
to
6037595
Compare
| } | ||
|
|
||
| @Test | ||
| public void shouldNotAllowDuplicateTitles() throws Exception { |
There was a problem hiding this comment.
We probably have to take into account the configuration here. On some systems this is allowed...
Fixes
#6303
#6055