Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up wizard for staff #55

Merged
merged 26 commits into from
Sep 30, 2016
Merged

Conversation

tommarmstrong
Copy link
Contributor

@tommarmstrong tommarmstrong commented Sep 27, 2016

Changes:

  • New signup page for academics, /clatoolkit/signup
    screenshot 2016-09-27 09 10 45
  • New page to create unit offerings, /clatoolkit/unitofferings/new
    screenshot 2016-09-27 09 14 06
    screenshot 2016-09-27 09 14 15
  • Updated myunits page to show number of members, a dynamic registration link for students and a link to update the unit offering (Unit Offering UI #48). Note: the registration page must now be accessed at a URI that includes the course code due to the new URI scheme used in this PR. This makes the URIs more consistent and means that students need to be invited to the course to join. Students who aren't supposed to join and that haven't been given the link shouldn't be able to sign up
    screenshot 2016-09-27 09 14 23
  • Updated registration page to allow users to use existing accounts. This works by showing a "Continue as user_name" button if a user is signed in already or by showing a login button under the register button
    screenshot 2016-09-27 11 30 06
  • New permissions model for unit offerings Change user roles for Units #47. Instead of generic Staff / Student roles, a user can be an admin of a unit offering which enables them to be able to do what a former Staff user could do for that course. Note: users who sign up with the new signup page are currently classified as Student and reference to roles still remains in some parts of the code.
  • Updated login to allow for redirection back to previous page (useful when using login_required directive)
  • General bug fixes esp in line with Rework registration, myunits pages #30

@zwaters
Copy link
Collaborator

zwaters commented Sep 27, 2016

Nice - I want to eventually "break-up" unit offerings by teaching period too (if applicable to a unit..). See: #20 - basically, if a staff user created a unit for Semester 1 2015, they would need to create another module for Semester 1 2016 (since the data is linked to the same unit code). I still haven't thought of the best way to implement this given our current data model, but this is moving some way towards that :)

@tommarmstrong
Copy link
Contributor Author

@zwaters That makes sense. I think that in line with issues #31 and #51, all references to units should be done via the ID of the unit instead of the course code which would then allow multiple units with the same course code to work.

Also, I think that non auto incrementing IDs could be a good thing to investigate so that the URIs for things are less predictable.

@tommarmstrong
Copy link
Contributor Author

@zwaters, I've created a new issue (#58) for this and can start work on it on Friday when I'm back at the office

@zwaters zwaters merged commit 3f2f037 into kirstykitto:development Sep 30, 2016
@tommarmstrong tommarmstrong deleted the registration-flow branch September 30, 2016 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants