utf-8

[hebaceous]

#109

[garronej]

Hi @hebaceous,

Have you tested this ?

If you want to support utf8 encoding it's not enough just to replace "ascii" by "utf8".

See the content-length does not refer to the number of character but to the number of byte.

As long as we work with asscii one character equal one byte so it is easy.
But in utf8 the body "✓" for exemple will be content-length: 3

Long story short look at this PR: #120

[hebaceous]

Yes, I used it online 2017-06-09 1:13 GMT+08:00 Garrone Joseph <[email protected]>:

…

Hi @hebaceous <https://github.com/hebaceous>, Have you tested this ? If you want to support utf8 encoding it's not enough just to replace "ascii" by "utf8". See the content-length does not refer to the number of character but to the number of byte. As long as we work with asscii one character equal one byte so it is easy. But in utf8 the body "✓" for exemple will be content-length: 3 Long story short look at this PR: #120 <#120> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#110 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGnraIJzCP-vuB5CqKs8YpATx0RmiCowks5sCCumgaJpZM4IhVNy> .

[garronej]

@hebaceous,

Even tho this fix had been working in your use case it is still incomplete/broken for the reasons that I gave earlier.

This PR should not be merged.

Respectuflly,