Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backend session stateless #786

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

Isti01
Copy link
Collaborator

@Isti01 Isti01 commented Sep 10, 2024

closes #362

@Isti01 Isti01 requested a review from Gerviba September 10, 2024 15:28
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cmsch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-g7 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-golyabal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-gtb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-qpa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-simonyi-szulinap ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-tanfolyam ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
cmsch-testing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:44pm
9 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cmsch-cst ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-felezo ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-golyakonf ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-golyakorte ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-karacsony ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-kozelokepzes ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-schnyari ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-seniortabor ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm
cmsch-snyt ⬜️ Ignored (Inspect) Dec 17, 2024 7:44pm

@@ -143,7 +142,7 @@ open class SecurityConfig(
http.formLogin { it.disable() }
http.exceptionHandling { it.accessDeniedPage("/403") }
http.with(JwtConfigurer(jwtTokenProvider), Customizer.withDefaults())
http.with(SessionFilterConfigurer(startupPropertyConfig), Customizer.withDefaults())
http.sessionManagement { it.sessionCreationPolicy(SessionCreationPolicy.STATELESS) }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work yet, the oauth2Login needs some config change

@@ -34,9 +34,6 @@ data class StartupPropertyConfig @ConstructorBinding constructor(
val challengeOwnershipMode: OwnershipType,
val raceOwnershipMode: OwnershipType,

// Increased session
val increasedSessionTime: Int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think, we need something like this but maybe in a different place.

@Gerviba
Copy link
Member

Gerviba commented Sep 10, 2024

That's a good one. Looking forward to see it work!

@Isti01 Isti01 force-pushed the staging branch 6 times, most recently from f2bfa50 to 9b84c4f Compare September 25, 2024 00:10
@Isti01 Isti01 force-pushed the staging branch 2 times, most recently from 96f4f73 to e42bcf9 Compare November 7, 2024 18:52
Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSESSIONID to custom JWT cookie
2 participants