Parameterize hardcoded strings in pdf generation #663
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
| // FIXME: place it into a setting | ||
| .add(Paragraph("GÓLYAKÖRTE 2023\nJELENLÉTI - ${group.name}") | ||
| readAsset(tokenComponent.reportLogo.getValue().replace("/cdn/", "/")).map { | ||
| Image(ImageDataFactory.create(it,)).scaleToFit(70f, 70f) |
There was a problem hiding this comment.
The comma is not required here after the it
| }.ifPresent(header::add) | ||
|
|
||
| val eventName = tokenComponent.reportTitle.getValue() | ||
| header.add(Paragraph("${eventName}\nJELENLÉTI - ${group.name}") |
There was a problem hiding this comment.
I might use a title variable here and not hardcode the 'JELENLÉTI' string.
| .add(kirdevLogo) | ||
| .setTextAlignment(TextAlignment.CENTER) | ||
|
|
||
| readAsset("/static/images/kirdev-logo.png").map { |
There was a problem hiding this comment.
Maybe make it optional using a boolean config variable? I'm not really sure.
There was a problem hiding this comment.
No no, we must show the kir-dev logo at every opportunity
| final val reportLogo = SettingProxy(componentSettingService, component, | ||
| "reportLogo", "/cdn/manifest/report-logo.png", | ||
| fieldName = "Jelenléti ív logója", description = "Ez lesz a jelenléti íven megjelenített logó (csak PNG és JPG jó)", | ||
| type = SettingType.IMAGE, |
There was a problem hiding this comment.
Do we have that setting type? I didn't remember that! :D
There was a problem hiding this comment.
Yes, it's for setting manifest images, and thats why I set it like /cdn/manifest/...
| @@ -29,15 +32,17 @@ class DI( | |||
| } | |||
| } | |||
|
|
|||
| private fun getFileStoragePath(): String = if (!DI.instance.startupPropertyConfig.external.startsWith("/")) { | |||
| System.getProperty("user.dir") + "/" + DI.instance.startupPropertyConfig.external | |||
There was a problem hiding this comment.
I'd just use the working directory for root and not the user.home
There was a problem hiding this comment.
I moved this code from the file upload function, I don't exactly understand why it works like this, so I didn't want to change it
Isti01
force-pushed
the
feature/parameterize-hardcoded-strings-in-pdf-generation
branch
from
6cd434a to
552d91e
Compare
Isti01
deleted the
feature/parameterize-hardcoded-strings-in-pdf-generation
branch
closes #661