Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added date sorting for GetDeckCards #95

Merged
merged 2 commits into from
Oct 4, 2023
Merged

added date sorting for GetDeckCards #95

merged 2 commits into from
Oct 4, 2023

Conversation

4KevR
Copy link
Contributor

@4KevR 4KevR commented Oct 4, 2023

This PR implements a default card sorting in the GetDeckCards method of the CardDeck service. The sorting is based on the creation time, therefore the model was adapted.

Closes #76.

@4KevR 4KevR added the enhancement New feature or request label Oct 4, 2023
@4KevR 4KevR self-assigned this Oct 4, 2023
darmiel
darmiel reviewed Oct 4, 2023
View reviewed changes
backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
backend/services/carddeck/handler/carddeck.go Outdated Show resolved Hide resolved
backend/store/postgres.go Show resolved Hide resolved
4KevR added a commit that referenced this pull request Oct 4, 2023
@4KevR
applied pr comments #95
ee46c4f
@4KevR 4KevR added the Backend Issues related to the Backend label Oct 4, 2023
TomRomeo
TomRomeo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@TomRomeo TomRomeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼🥰

@4KevR 4KevR force-pushed the feature/card-sorting branch from ee46c4f to c0791e2 Compare October 4, 2023 15:09
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

[Kioku Frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

[Kioku Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@4KevR 4KevR merged commit c0791e2 into main Oct 4, 2023
14 checks passed
@4KevR 4KevR deleted the feature/card-sorting branch October 4, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darmiel darmiel darmiel approved these changes

@Julian702 Julian702 Julian702 approved these changes

@TomRomeo TomRomeo TomRomeo approved these changes

@memeToasty memeToasty memeToasty approved these changes

Assignees

@4KevR 4KevR

Labels
Backend Issues related to the Backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Card Sorting
5 participants
@4KevR @memeToasty @TomRomeo @Julian702 @darmiel