Add Speech Bubble and Placeholder Component #287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonie2003
added
enhancement
Julian702
changed the title
Julian702
requested changes
Apr 24, 2024
There was a problem hiding this comment.
I really like how the placeholder and tutorials look and feel like :) Great job!
I have some first comments for further improvements:
- I would like to rename Speech Bubble to Popover
- Placeholder instead of GenericPlaceholder would be fine
- Pass the placeholder component to the Deck- and GroupList as placeholder prop instead of children and move check inside the list component
| */ | ||
| align: "left" | "center" | "right" | string; | ||
| /** | ||
| * Show |
| */ | ||
| children: ReactNode; | ||
| /** | ||
| * |
Comment on lines
+54
to
+55
| console.log("SpeechBubble"); | ||
| console.log(child); |
There was a problem hiding this comment.
Remove console.log statements
Comment on lines
+14
to
+16
| /** | ||
| * UI component for displaying a DangerAction | ||
| */ |
Comment on lines
+23
to
+28
| <> | ||
| {Children.map(children, (child) => { | ||
| if (!isValidElement(child)) return null; | ||
| return child; | ||
| })} | ||
| </> |
There was a problem hiding this comment.
Why do we have to check for a valid element and not just return the child?
Comment on lines
+80
to
+85
| className={`w-sm${ | ||
| writePermission | ||
| ? "cursor-pointer text-kiokuDarkBlue hover:scale-110" | ||
| : "text-gray-400 hover:cursor-not-allowed" | ||
| } ${showTutorial ? "animate-bounce" : ""} flex-none | ||
| transition |
There was a problem hiding this comment.
I know it's not part of your PR but could you change this snippet to use clsx instead?
Comment on lines
+39
to
+58
| const parent = Children.map(children, (child) => { | ||
| if ( | ||
| isValidElement(child) && | ||
| typeof child.type !== "string" && | ||
| child.type.name == "SpeechBubbleParent" | ||
| ) { | ||
| return child; | ||
| } | ||
| }); | ||
| const content = Children.map(children, (child) => { | ||
| if ( | ||
| isValidElement(child) && | ||
| typeof child.type !== "string" && | ||
| child.type.name == "SpeechBubbleContent" | ||
| ) { | ||
| console.log("SpeechBubble"); | ||
| console.log(child); | ||
| return child; | ||
| } | ||
| }); |
There was a problem hiding this comment.
Please change this to a single Children.forEach() call and set both variables according to the if statements.
| setShowTutorial(false); | ||
| }} | ||
| showTutorial={showTutorial} | ||
| tutorialText="Click here to create a new group!" |
Comment on lines
+34
to
+36
| /** | ||
| * UI component for displaying a DangerAction | ||
| */ |
Comment on lines
+47
to
+51
| <div {...props} className={className}> | ||
| <div | ||
| className="flex min-h-[6.5rem] w-full flex-row gap-x-4 rounded-md border-2 border-dashed border-neutral-300 bg-gradient-to-l to-60% p-3 hover:from-neutral-50 sm:min-h-28 md:min-h-32 lg:min-h-32 | ||
| " | ||
| > |
There was a problem hiding this comment.
Can these two divs be merged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the placeholder component and speech bubble component.
Resolved Issues
resolves #249