Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Selection Field Component #267

Merged
merged 9 commits into from
Mar 9, 2024
Merged

Conversation

leonie2003
Copy link
Contributor

@leonie2003 leonie2003 commented Mar 4, 2024

Description

Add Selection Field Component that accepts a list of options (icon, title, description) as input.

Resolved Issues

Resolves #260

@leonie2003 leonie2003 self-assigned this Mar 4, 2024
@leonie2003 leonie2003 requested a review from a team as a code owner March 4, 2024 17:57
@leonie2003 leonie2003 requested a review from Julian702 March 4, 2024 17:57
@Julian702 Julian702 added enhancement New feature or request Frontend Issues related to the Frontend labels Mar 4, 2024
Copy link
Member

@Julian702 Julian702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great already, here are my first comments on some details :)

frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
Copy link
Member

@Julian702 Julian702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some more comments on this. Moreover I think we should avoid fixed widths in the component and define the width by setting additional classnames in the parent.

frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
frontend/components/input/SelectionField.tsx Outdated Show resolved Hide resolved
@Julian702
Copy link
Member

We also need a story for the new component.

Copy link
Contributor

@memeToasty memeToasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great int the UI!

@Julian702 Julian702 force-pushed the feature/frontend/selection-field branch from db66a8c to 643f262 Compare March 8, 2024 20:33
Copy link

sonarqubecloud bot commented Mar 8, 2024

Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed for 'Kioku Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Julian702 Julian702 merged commit 5510d43 into main Mar 9, 2024
9 checks passed
@Julian702 Julian702 deleted the feature/frontend/selection-field branch March 9, 2024 16:00
@leonie2003 leonie2003 assigned Julian702 and unassigned leonie2003 Mar 9, 2024
@leonie2003 leonie2003 removed their assignment Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Frontend Issues related to the Frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SelectionField component
5 participants