-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Selection Field Component #267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great already, here are my first comments on some details :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some more comments on this. Moreover I think we should avoid fixed widths in the component and define the width by setting additional classnames in the parent.
We also need a story for the new component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great int the UI!
Co-authored-by: Tom <[email protected]>
db66a8c
to
643f262
Compare
Quality Gate passed for 'Kioku Frontend'Issues Measures |
Quality Gate passed for 'Kioku Backend'Issues Measures |
Description
Add Selection Field Component that accepts a list of options (icon, title, description) as input.
Resolved Issues
Resolves #260