Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in frontend and backend #265

Merged
merged 16 commits into from
Mar 17, 2024
Merged

Fix error handling in frontend and backend #265

merged 16 commits into from
Mar 17, 2024

Conversation

TomRomeo
Copy link
Contributor

Description

This PR clarifies error messages in the backend and improves error display in the frontend with new toast library

Resolved Issues

resolves #63

@TomRomeo TomRomeo added bug Something isn't working Frontend Issues related to the Frontend Backend Issues related to the Backend Refactor Issues regarding Refactoring labels Feb 27, 2024
@TomRomeo TomRomeo self-assigned this Feb 27, 2024
@TomRomeo TomRomeo requested a review from a team as a code owner February 27, 2024 12:58
Julian702
Julian702 reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@Julian702 Julian702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the sonarcloud issues :)

darmiel
darmiel approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@darmiel darmiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta

backend/pkg/helper/security.go Show resolved Hide resolved
Julian702
Julian702 requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Julian702 Julian702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, just some implementation details we should check

backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
frontend/components/graphics/LoadingSpinner.stories.ts Outdated Show resolved Hide resolved
frontend/components/input/NotificationButton.tsx Outdated Show resolved Hide resolved
frontend/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
frontend/pages/login.tsx Outdated Show resolved Hide resolved
frontend/util/api.ts Outdated Show resolved Hide resolved
4KevR
4KevR reviewed Mar 4, 2024
View reviewed changes
Copy link
Contributor

@4KevR 4KevR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Did not check in local build, I have some comments beforehand. Also, in some places, strange occurrences of commas appeared (see last comment), was this intended?

backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
backend/services/collaboration/handler/collaboration.go Show resolved Hide resolved
backend/services/user/handler/user.go Show resolved Hide resolved
backend/services/user/handler/user.go Show resolved Hide resolved
frontend/pages/login.tsx Outdated Show resolved Hide resolved
memeToasty
memeToasty approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@memeToasty memeToasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new toast looks awesome!
Finally the weird toast bug is gone as well 🤣

Because of this PR, I could find the small bug in the learning view!
Thank you very much for this

Julian702
Julian702 requested changes Mar 6, 2024
View reviewed changes
frontend/components/input/NotificationButton.tsx Outdated Show resolved Hide resolved
frontend/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
frontend/pages/login.tsx Outdated Show resolved Hide resolved
frontend/pages/login.tsx Outdated Show resolved Hide resolved
frontend/util/api.ts Outdated Show resolved Hide resolved
frontend/util/api.ts Outdated Show resolved Hide resolved
frontend/util/api.ts Outdated Show resolved Hide resolved
frontend/util/api.ts Outdated Show resolved Hide resolved
frontend/util/toasts.ts Outdated Show resolved Hide resolved
frontend/util/api.ts Show resolved Hide resolved
@TomRomeo TomRomeo requested a review from Julian702 March 9, 2024 18:55
@Julian702 Julian702 requested a review from 4KevR March 13, 2024 08:02
Julian702
Julian702 requested changes Mar 13, 2024
View reviewed changes
frontend/util/api.ts Outdated Show resolved Hide resolved
4KevR
4KevR requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@4KevR 4KevR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested locally, the new toast looks awesome! Found two issues.

backend/services/frontend/handler/frontend.go Show resolved Hide resolved
backend/services/frontend/handler/frontend.go Show resolved Hide resolved
@TomRomeo TomRomeo requested a review from 4KevR March 15, 2024 12:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Kioku Frontend'

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'Kioku Backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
34.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@TomRomeo TomRomeo merged commit 8b7c048 into main Mar 17, 2024
15 checks passed
@TomRomeo TomRomeo deleted the fix/error-handling branch March 17, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darmiel darmiel darmiel approved these changes

@Julian702 Julian702 Julian702 approved these changes

@4KevR 4KevR 4KevR approved these changes

@memeToasty memeToasty memeToasty approved these changes

Assignees

@TomRomeo TomRomeo

Labels
Backend Issues related to the Backend bug Something isn't working Frontend Issues related to the Frontend Refactor Issues regarding Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error handling
5 participants
@TomRomeo @memeToasty @4KevR @Julian702 @darmiel