Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure pwa and add notifications #231

Merged
merged 47 commits into from
Feb 1, 2024
Merged

Configure pwa and add notifications #231

merged 47 commits into from
Feb 1, 2024

Conversation

Julian702
Copy link
Member

@Julian702 Julian702 commented Jan 16, 2024 •
edited
Loading

Description

This pr configures Kioku to be installed as a pwa. Moreover it adds notifications to Kioku.
To enable notifications, go to settings and click "Subscribe". On mobile devices you have to install the pwa first. A tutorial will be displayed when you click on "Install Kioku"

@Julian702 Julian702 added enhancement New feature or request Frontend Issues related to the Frontend labels Jan 16, 2024
@Julian702 Julian702 self-assigned this Jan 16, 2024
This was linked to issues Jan 18, 2024
Configure Kioku to be installable as pwa #235
Closed
Enable native system notifications #236
Closed
@Julian702 Julian702 changed the title Configure pwa Configure pwa and add notifications Jan 23, 2024
@JJthere JJthere self-requested a review January 31, 2024 09:12
darmiel
darmiel reviewed Jan 31, 2024
View reviewed changes
backend/pkg/util/number.go Outdated Show resolved Hide resolved
backend/services/frontend/handler/frontend.go Outdated Show resolved Hide resolved
4KevR
4KevR requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@4KevR 4KevR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just have a couple of nits

backend/services/notifications/.gitignore Outdated Show resolved Hide resolved
backend/services/notifications/Dockerfile Outdated Show resolved Hide resolved
backend/services/notifications/main.go Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
frontend/components/navigation/Tabs/UserSettingsTab.tsx Outdated Show resolved Hide resolved
frontend/locales/de/messages.po Outdated Show resolved Hide resolved
frontend/locales/de/messages.po Outdated Show resolved Hide resolved
backend/pkg/helper/errors.go Outdated Show resolved Hide resolved
backend/.env.example Show resolved Hide resolved
@Julian702 Julian702 removed the request for review from TomRomeo January 31, 2024 15:34
@4KevR
Copy link
Contributor

4KevR commented Jan 31, 2024

We should also add a new GitHub Actions Workflow for the new service and adjust our manual release build, @TomRomeo

@TomRomeo
Copy link
Contributor

We should also add a new GitHub Actions Workflow for the new service and adjust our manual release build, @TomRomeo

You are right. I added the missing workflows in 4c4ba0f

memeToasty
memeToasty requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@memeToasty memeToasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid work guys!
I love the feature!

Just smaller questions

backend/services/notifications/handler/notifications.go Outdated Show resolved Hide resolved
backend/services/notifications/main.go Outdated Show resolved Hide resolved
backend/services/notifications/main.go Outdated Show resolved Hide resolved
frontend/public/manifest.json Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed for 'Kioku Frontend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed for 'Kioku Backend'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

memeToasty
memeToasty approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@memeToasty memeToasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TA

@Julian702 Julian702 merged commit 97ea866 into main Feb 1, 2024
15 checks passed
@Julian702 Julian702 deleted the feature/frontend/pwa branch February 1, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darmiel darmiel darmiel approved these changes

@TomRomeo TomRomeo TomRomeo left review comments

@leonie2003 leonie2003 leonie2003 approved these changes

@JJthere JJthere JJthere approved these changes

@4KevR 4KevR 4KevR approved these changes

@memeToasty memeToasty memeToasty approved these changes

Assignees

@TomRomeo TomRomeo

@Julian702 Julian702

Labels
enhancement New feature or request Frontend Issues related to the Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable native system notifications Configure Kioku to be installable as pwa
7 participants
@Julian702 @TomRomeo @4KevR @memeToasty @darmiel @JJthere @leonie2003