Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: this refactor pr refactors some code which had to be refactored #109

Merged
merged 5 commits into from
Oct 9, 2023
Merged

refactor: this refactor pr refactors some code which had to be refactored #109

merged 5 commits into from
Oct 9, 2023

Conversation

darmiel
Copy link
Contributor

@darmiel darmiel commented Oct 6, 2023

No description provided.

@darmiel darmiel assigned TomRomeo and unassigned darmiel Oct 6, 2023
@TomRomeo TomRomeo added the Refactor Issues regarding Refactoring label Oct 6, 2023
@darmiel darmiel self-assigned this Oct 6, 2023
memeToasty
memeToasty requested changes Oct 6, 2023
View reviewed changes
backend/services/carddeck/handler/health.go Outdated Show resolved Hide resolved
backend/services/collaboration/handler/health.go Outdated Show resolved Hide resolved
backend/services/frontend/handler/health.go Outdated Show resolved Hide resolved
backend/services/srs/handler/health.go Outdated Show resolved Hide resolved
backend/services/user/handler/health.go Outdated Show resolved Hide resolved
@darmiel darmiel requested a review from memeToasty October 6, 2023 08:18
TomRomeo
TomRomeo requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@TomRomeo TomRomeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Sonarcloud code smell and code duplication.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

[Kioku Frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

[Kioku Backend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

3.5% 3.5% Coverage
1.9% 1.9% Duplication

@darmiel darmiel merged commit e1632fa into main Oct 9, 2023
12 checks passed
@darmiel darmiel deleted the refactor/nittis branch October 9, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian702 Julian702 Julian702 approved these changes

@TomRomeo TomRomeo TomRomeo approved these changes

@4KevR 4KevR 4KevR approved these changes

@memeToasty memeToasty memeToasty approved these changes

Assignees

@TomRomeo TomRomeo

@darmiel darmiel

Labels
Refactor Issues regarding Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darmiel @memeToasty @4KevR @TomRomeo @Julian702