Skip to content

Commit

Permalink
fixed config
Browse files Browse the repository at this point in the history
  • Loading branch information
tobschli committed Oct 2, 2023
1 parent 6c65816 commit 0a0b880
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
8 changes: 4 additions & 4 deletions backend/pkg/helper/tracing.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/propagation"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp"
"go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc"
"go.opentelemetry.io/otel/sdk/resource"
"go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.12.0"
Expand All @@ -15,11 +15,11 @@ import (
func SetupTracing(ctx context.Context, serviceName string) (*trace.TracerProvider, error) {
tracingUrl := os.Getenv("TRACING_COLLECTOR")
if tracingUrl == "" {
tracingUrl = "simple-prod-collector.observability.svc.cluster.local:4318"
tracingUrl = "simple-prod-collector.observability.svc.cluster.local:4317"
}
exporter, err := otlptracehttp.New(
exporter, err := otlptracegrpc.New(
ctx,
otlptracehttp.WithEndpoint(tracingUrl),
otlptracegrpc.WithEndpoint(tracingUrl),
)
if err != nil {
return nil, err
Expand Down
2 changes: 1 addition & 1 deletion helm/kioku/templates/frontend_proxy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ spec:
envFrom:
- configMapRef:
name: service-env
-configMapRef:
- configMapRef:
name: tracing-config
- secretRef:
name: {{ .Values.frontend_proxy.keySecret }}
Expand Down
1 change: 0 additions & 1 deletion helm/kioku/templates/jaeger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,5 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: tracing-config
namespace: observability
data:
TRACING_COLLECTOR: "simple-prod-collector.observability.svc.cluster.local:4318"

0 comments on commit 0a0b880

Please sign in to comment.