Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrapper around the messenger service #95

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

gk-kindred
Copy link
Collaborator

Similar to the thin wrapper for talos_certifier using kafka called certifier_kafka_pg.

A thin wrapper is created for the messenger called messenger_with_kafka , so that the consumers, be it our own example binary or some other binary, can use the messenger with kafka consumer and producer by passing just the minimum configs required.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (127d304) 57.00% compared to head (8c45361) 56.94%.

Files Patch % Lines
...alos_messenger_actions/src/messenger_with_kafka.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   57.00%   56.94%   -0.06%     
==========================================
  Files         113      113              
  Lines        5707     5711       +4     
==========================================
- Hits         3253     3252       -1     
- Misses       2454     2459       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gk-kindred gk-kindred force-pushed the feature/messenger-wrapper branch from d456b00 to 8c45361 Compare November 24, 2023 04:07
@gk-kindred gk-kindred merged commit ab9dfbc into master Nov 24, 2023
2 of 4 checks passed
@gk-kindred gk-kindred deleted the feature/messenger-wrapper branch November 24, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants