Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement uninstall step in the workflow #91

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat: Implement uninstall step in the workflow #91

merged 2 commits into from
Oct 26, 2023

Conversation

fmarek-kindred
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/build_sdk_manually@f40de62). Click here to learn what that means.

❗ Current head c82b616 differs from pull request most recent head 16baff5. Consider uploading reports for the commit 16baff5 to get more accurate results

Additional details and impacted files 
@@                      Coverage Diff                      @@
##             feature/build_sdk_manually      #91   +/-   ##
=============================================================
  Coverage                              ?   57.08%           
=============================================================
  Files                                 ?      115           
  Lines                                 ?     5663           
  Branches                              ?        0           
=============================================================
  Hits                                  ?     3233           
  Misses                                ?     2430           
  Partials                              ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gk-kindred
Copy link
Collaborator

gk-kindred commented Oct 25, 2023 •
edited
Loading

The solution looks fine to unpublish.

Although I am thinking, do we need to go this path of

  • publish then find something doesn't work and then unpublish
  • Or we do some tests (minus ARM architecture, due to openssl), and then publish only if the tests pass?

@fmarek-kindred fmarek-kindred merged commit 72af4b5 into feature/build_sdk_manually Oct 26, 2023
2 checks passed
@fmarek-kindred fmarek-kindred deleted the feature/unpublish_on_failure branch October 26, 2023 05:52
fmarek-kindred added a commit that referenced this pull request Oct 26, 2023
@fmarek-kindred
feat: Change workflow trigger to manually build SDK (#90)
800228e 
* feat: Change workflow trigger to manually build SDK

* feat: fix Type in trigger name for manually building workflow

* feat: Implement uninstall step in the workflow (#91)

* feat: Implement uninstall step in the workflow

* feat: Improve SDK readme docs (#92)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gk-kindred gk-kindred gk-kindred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmarek-kindred @gk-kindred