Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change workflow trigger to manually build SDK #90

Merged
merged 3 commits into from
Oct 26, 2023

Conversation

fmarek-kindred
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (ab815a2) 57.08% compared to head (8746119) 57.36%.
Report is 1 commits behind head on master.

❗ Current head 8746119 differs from pull request most recent head 72af4b5. Consider uploading reports for the commit 72af4b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
+ Coverage   57.08%   57.36%   +0.27%     
==========================================
  Files         115      115              
  Lines        5663     5747      +84     
==========================================
+ Hits         3233     3297      +64     
- Misses       2430     2450      +20     
Files Coverage Δ
.../talos_certifier/src/services/certifier_service.rs 91.56% <100.00%> (+0.65%) ⬆️
..._certifier/src/services/decision_outbox_service.rs 89.74% <100.00%> (+1.33%) ⬆️
..._certifier/src/services/tests/certifier_service.rs 100.00% <100.00%> (ø)
...fier/src/services/tests/decision_outbox_service.rs 82.62% <100.00%> (+0.60%) ⬆️
...ckages/talos_certifier_adapters/src/kafka/utils.rs 78.46% <ø> (ø)
...ier/src/services/tests/message_receiver_service.rs 76.40% <96.77%> (+1.70%) ⬆️
packages/talos_messenger_core/src/core.rs 0.00% <0.00%> (ø)
...ges/talos_certifier_adapters/src/kafka/producer.rs 0.00% <0.00%> (ø)
...s_certifier_adapters/src/mock_certifier_service.rs 0.00% <0.00%> (ø)
...ages/talos_messenger_actions/src/kafka/producer.rs 0.00% <0.00%> (ø)
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -8,8 +8,8 @@

name: Build and Publish Cohort SDK NPMs
on:
#workflow_call:
push:
workflow_call:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should use workflow_dispatch for manual trigger, instead of workflow_call

* feat: Implement uninstall step in the workflow

* feat: Improve SDK readme docs (#92)
@fmarek-kindred fmarek-kindred merged commit 800228e into master Oct 26, 2023
2 checks passed
@fmarek-kindred fmarek-kindred deleted the feature/build_sdk_manually branch October 26, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants