feature: Publish cohort SDK NPSs with bundled rust src #85
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
=======================================
Coverage 57.10% 57.10%
=======================================
Files 115 115
Lines 5670 5670
=======================================
Hits 3238 3238
Misses 2432 2432 ☔ View full report in Codecov by Sentry. |
| - name: Setup node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 |
There was a problem hiding this comment.
We have ticket to do testing with node 18. If we are going to support both then the whole workflow should be different in the way that it should be publishing two artefacts, one for v16 and one for v18. I prefer to have that work done as separate ticket (if we need to do it)
| @@ -0,0 +1,121 @@ | |||
| # Cohort Initiator JS App | |||
There was a problem hiding this comment.
Nice 👍 👍 Thanks for writing this
| cargo --version && rustc --version && rustup --version | ||
|
|
||
| cargo 1.72.0 (103a7ff2e 2023-08-15) | ||
| rustc 1.72.0 (5680fa18f 2023-08-23) |
There was a problem hiding this comment.
We just bumped to 1.73 :-) Maybe safer to mention stable and (1.73 at the time of writing this)
fmarek-kindred
deleted the
feature/publish_cohort_sdk_npm_with_bundled_rust_src
branch
No description provided.