Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimise replicator commit logic #82

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

fmarek-kindred
Copy link
Contributor

  • Fix for offset lag in the replicator kafka group
  • Fix for too frequent commits in certifier
  • Commit change from sync to async.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 4.54% and project coverage change: -0.23% ⚠️

Comparison is base (29cee52) 60.15% compared to head (4f3233e) 59.93%.

❗ Current head 4f3233e differs from pull request most recent head 6d4e528. Consider uploading reports for the commit 6d4e528 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   60.15%   59.93%   -0.23%     
==========================================
  Files          96       96              
  Lines        5132     5151      +19     
==========================================
  Hits         3087     3087              
- Misses       2045     2064      +19     
Files Changed Coverage Δ
...ier/src/services/tests/message_receiver_service.rs 77.50% <0.00%> (-3.02%) ⬇️
...ges/talos_certifier_adapters/src/kafka/consumer.rs 0.00% <0.00%> (ø)
packages/talos_cohort_replicator/src/core.rs 9.52% <ø> (ø)
...certifier/src/services/message_receiver_service.rs 66.66% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gk-kindred gk-kindred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :-)

@fmarek-kindred fmarek-kindred merged commit d6eb1fe into master Sep 25, 2023
2 checks passed
@fmarek-kindred fmarek-kindred deleted the feature/optimise_replicator_commit_logic branch September 25, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants