feat: Cohort Replicator JS #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarek-kindred
commented
Sep 12, 2023
| while (attemptNr <= retry.maxAttempts) { | ||
| attemptNr++ | ||
|
|
||
| if (attemptNr > retry.maxAttempts) { |
There was a problem hiding this comment.
This one is missing in Replicator Rust example!
fmarek-kindred
commented
Sep 12, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 60.15% 58.16% -1.99%
==========================================
Files 96 103 +7
Lines 5132 5314 +182
==========================================
+ Hits 3087 3091 +4
- Misses 2045 2223 +178
☔ View full report in Codecov by Sentry. |
fmarek-kindred
commented
Sep 12, 2023
* feat: Initial draft for errors handling between Rust and JS * fix: Remove cohort_sdk_js dependency, instead declare optional dependencies on images. * fix: Inject using serde annotation _typ during serialisation into JSON. * fix: Improve error handling when processig callback calls between JS and RS. * feat: Add ReplicatorError and map it to JS layer. (#81) * feat: Add wrapper and error handler for Replicator JS. * feat: Add ReplicatorError and map it to JS layer. * fix: Move dev dependencies into relevant section in the package.json
gk-kindred
approved these changes
Sep 25, 2023
| let database = Database::init_db(cfg_db).await.map_err(|e| e.to_string()).unwrap(); | ||
| let database = Database::init_db(cfg_db.clone()) | ||
| .await | ||
| .map_err(|e| e.to_string()) |
There was a problem hiding this comment.
don't need this map_err as you are chaining that with expect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we merge that one, as separate work, I will finish renaming of cohort packages.
There are many files in this PR but mostly because of import change and moving classes around.