feat: messenger improve latency #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gk-kindred
force-pushed
the
feature/messenger-state-transition-timings
branch
from
f72b5b9 to
38496b7
Compare
| @@ -93,6 +93,10 @@ pub struct Configuration { | |||
| pub allowed_actions: HashMap<String, Vec<String>>, | |||
| /// Channel buffer size for the internal channels between threads | |||
| pub channel_buffers: Option<ChannelBuffers>, | |||
| /// Commit size to decide how often the certifier topic can be committed by the consumer. | |||
| /// The more ofter the commit is done has inverse impact on the latency. | |||
|
|
||
| }, | ||
| MessengerChannelFeedback::Success(version, key) => { | ||
| info!("Successfully processed version={version} with action_key={key}"); |
There was a problem hiding this comment.
Should it be debug instead of info, to reduce a noise in the log?
fmarek-kindred
approved these changes
Nov 11, 2024
|
The base suffix hasn't changed. Messenger uses the base suffix from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.