feat: Initial draft for errors handling between Rust and JS

kindredgroup · Sep 18, 2023 · 8a917ae · 8a917ae
1 parent f261ebf
commit 8a917ae
Show file tree

Hide file tree

Showing 18 changed files with 2,329 additions and 904 deletions.
diff --git a/cohort_banking_initiator_js/package-lock.json b/cohort_banking_initiator_js/package-lock.json
diff --git a/cohort_banking_initiator_js/package.json b/cohort_banking_initiator_js/package.json
@@ -17,6 +17,7 @@
   },
   "dependencies": {
     "@types/pg": "^8.10.2",
+    "cohort_sdk_client": "file:../cohort_sdk_client",
     "cohort_sdk_js": "file:../packages/cohort_sdk_js",
     "nodejs-dashboard": "^0.5.1",
     "pg": "^8.11.3",

diff --git a/cohort_banking_initiator_js/src/banking-app.ts b/cohort_banking_initiator_js/src/banking-app.ts
@@ -5,9 +5,9 @@ import { Pond } from "./pond"
 
 import { logger } from "./logger"
 
-import { CapturedItemState, CapturedState, CertificationCandidate, CertificationRequest, TransferRequest, TransferRequestMessage } from "./model"
-import { Initiator, JsCertificationRequestPayload, OutOfOrderRequest } from "cohort_sdk_js"
+import { CapturedItemState, CapturedState, TransferRequest, TransferRequestMessage } from "./model"
 import { SDK_CONFIG as sdkConfig } from "./cfg/config-cohort-sdk"
+import { Initiator, JsCertificationRequestPayload, OutOfOrderRequest } from "cohort_sdk_client"
 
 export class BankingApp {
     private startedAtMs: number = 0
@@ -25,13 +25,14 @@ export class BankingApp {
 
     async init() {
         this.initiator = await Initiator.init(sdkConfig)
+
         this.queue.onmessage = (event: MessageEvent<TransferRequestMessage>) => {
             this.pond.submit(async () => {
                 try {
                     const spans = await this.processQueueItem(event)
                     this.spans.push(spans)
                 } catch (e) {
-                    logger.error("Failed to process tx: %s", e)
+                    logger.error("%s", e)
                 }
             })
         }
@@ -59,7 +60,7 @@ export class BankingApp {
             const subSpans = await this.handleTransaction(event.data.request)
             spans.processDetails = subSpans
         } catch (e) {
-            logger.error("Unable to process tx: %s. Error:: %s", JSON.stringify(event.data), e)
+            logger.error("Unable to process tx: %s. Error: %s", JSON.stringify(event.data), e)
         } finally {
             this.handledCount++
             spans.process = Date.now() - span_s
@@ -148,7 +149,7 @@ export class BankingApp {
             return new CapturedState(Number(result.rows[0].snapshot_version), items)
         } catch (e) {
             logger.error("BankingApp.loadState(): %s", e)
-            throw e
+            throw new Error(`Unable to load state for tx: ${ JSON.stringify(tx) }`, { cause: e })
         } finally {
             cnn?.release()
         }
@@ -203,6 +204,7 @@ export class BankingApp {
 
         } catch (e) {
             logger.error("BankingApp.installOutOfOrder(): %s", e)
+            throw new Error(`Unable to complete out of order installation of tx: ${ JSON.stringify(tx) }`, { cause: e })
         } finally {
             cnn?.release()
         }

diff --git a/cohort_banking_initiator_js/src/cfg/config-cohort-sdk.ts b/cohort_banking_initiator_js/src/cfg/config-cohort-sdk.ts
@@ -1,4 +1,4 @@
-import { JsInitiatorConfig } from "cohort_sdk_js"
+import { JsInitiatorConfig } from "cohort_sdk_client"
 
 const SDK_CONFIG: JsInitiatorConfig = {
     backoffOnConflict: {

diff --git a/cohort_banking_initiator_js/src/main.ts b/cohort_banking_initiator_js/src/main.ts
@@ -6,6 +6,7 @@ import { createGeneratorService } from "./load-generator"
 import { BankingApp } from "./banking-app"
 import { DB_CONFIG } from "./cfg/config-db-pool"
 import { Pond } from "./pond"
+import { TalosSdkError, SdkErrorKind } from "cohort_sdk_client"
 
 logger.info("App: Cohort JS Application: %d", 111)
 logger.info("App: ---------------------")
@@ -46,6 +47,45 @@ class LaunchParams {
 new Promise(async (resolve) => {
     const params = LaunchParams.parse(process.argv)
 
+    // try {
+    //     new SomeRustServiceClass().testCatchWrapAndThrow()
+    // } catch (e) {
+    //     console.log(e.message)
+    //     console.log(e)
+    //     console.log(e.cause)
+    //     return
+    // }
+
+    // try {
+    //     new SomeRustServiceClass().example1DirectThrow(100)
+    // } catch (e) {
+    //     logger.info("-  -  -  -  -  -  -  -  App caught error  -  -  -  -  -  -  -  -  -  -  -  -")
+    //     if (e instanceof TalosSdkError) {
+    //         if (e.code === 100) {
+    //             logger.error("Caught TalosSdkError with code 100: %s\n%s\n%s", e.message, e, e.cause)
+    //         } else {
+    //             logger.error("Caught TalosSdkError with unexpected code: %s. Error: %s", e.code, e)
+    //         }
+    //     } else {
+    //         logger.error("Caught some generic Error:\ndetails:\n\t%s", e)
+    //     }
+    //     logger.info("-  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -")
+    //     throw e
+    // }
+
+    // try {
+    //     new SomeRustServiceClass().example2SimulateRustError()
+    // } catch (e) {
+    //     logger.info("-  -  -  -  -  -  -  -  App caught error  -  -  -  -  -  -  -  -  -  -  -  -")
+    //     if (e instanceof TalosSdkError) {
+    //         logger.error("Caught TalosSdkError:\n%s\n%s", e.message, e, e.cause)
+    //     } else {
+    //         logger.error("Caught some generic Error:\ndetails:\n\t%s", e)
+    //     }
+    //     logger.info("-  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -  -")
+    //     throw e
+    // }
+
     const database = new Pool(DB_CONFIG)
     database.on("error",   (e, _) => { logger.error("DBPool.error: Error: %s", e) })
     database.on("release", (e, _) => { if (e) { logger.error("DBPool.release: Error: %s", e) } })
@@ -71,6 +111,16 @@ new Promise(async (resolve) => {
         queue,
         fnFinish,
     )
-    await app.init()
+    try {
+        await app.init()
+    } catch (e) {
+        if (e instanceof TalosSdkError) {
+            const sdkError = e as TalosSdkError
+            if (sdkError.kind == SdkErrorKind.Messaging) {
+                logger.error("Unable to connect to kafka....")
+            }
+            throw e
+        }
+    }
     const _worker = createGeneratorService({ channelName: CHANNEL_NAME, count: params.transactionsCount, rate: params.targetRatePerSecond })
 })