fix: Fix aarch build and yml syntax

kindredgroup · Sep 27, 2023 · 5d5f516 · 5d5f516
1 parent c03c04f
commit 5d5f516
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/.github/workflows/npm.yml b/.github/workflows/npm.yml
@@ -3,7 +3,6 @@ on:
     #workflow_call:
     push:
 env:
-    LIBRARY_NAME: cohort_sdk_js
     DEBUG: "napi:*"
 jobs:
     npm:
@@ -14,31 +13,32 @@ jobs:
                   - host: macos-latest
                     target: x86_64-apple-darwin
                     jsPackageHome: packages/cohort_sdk_js
-                    finalPackageName: packages/cohort_sdk_js/${{ env.LIBRARY_NAME }}.darwin-x64.node
+                    finalPackageName: packages/cohort_sdk_js/cohort_sdk_js.darwin-x64.node
                     customiseHostCommand: echo 'No customisartions are needed'
                     buildCommand: npm run build -- --target x86_64-apple-darwin
 
                   - host: macos-latest
                     target: aarch64-apple-darwin
                     jsPackageHome: packages/cohort_sdk_js
-                    finalPackageName: packages/cohort_sdk_js/${{ env.LIBRARY_NAME }}.darwin-arm64.node
+                    finalPackageName: packages/cohort_sdk_js/cohort_sdk_js.darwin-arm64.node
                     customiseHostCommand: |-
                         brew update && brew install cyrus-sasl &&
                         export PKG_CONFIG_PATH="/usr/local/opt/cyrus-sasl/lib/pkgconfig" &&
-                        ls -lah $PKG_CONFIG_PATH
+                        export PATH="/usr/local/opt/cyrus-sasl/sbin:$PATH" >> /Users/runner/.bash_profile &&
+                        echo "ls -lah $PKG_CONFIG_PATH" && ls -lah $PKG_CONFIG_PATH
                     buildCommand: npm run build -- --target aarch64-apple-darwin
 
                   - host: windows-latest
                     target: x86_64-pc-windows-msvc
                     jsPackageHome: packages\cohort_sdk_js
-                    finalPackageName: packages/cohort_sdk_js/${{ env.LIBRARY_NAME }}.*.node
+                    finalPackageName: packages/cohort_sdk_js/cohort_sdk_js.*.node
                     customiseHostCommand: ECHO 'No customisartions are needed'
                     buildCommand: npm run build -- --target x86_64-pc-windows-msvc
-                    
+
                   - host: ubuntu-latest
                     target: x86_64-unknown-linux-gnu
                     jsPackageHome: packages/cohort_sdk_js
-                    finalPackageName: packages/cohort_sdk_js/${{ env.LIBRARY_NAME }}.linux-x64-gnu.node
+                    finalPackageName: packages/cohort_sdk_js/cohort_sdk_js.linux-x64-gnu.node
                     customiseHostCommand: sudo apt-get update -y && sudo apt-get install -y libsasl2-dev
                     buildCommand: npm run build -- --target x86_64-unknown-linux-gnu