fix: Add 'npm build' step when publishing cohort_sdk_client; examples…

…/cohort_banking_with_sdk.rs should load configs from env; Do not print misleading througput from duration histograms;
kindredgroup · Jul 15, 2024 · 4ffd40a · 4ffd40a
1 parent 4bdc6d4
commit 4ffd40a
Show file tree

Hide file tree

Showing 14 changed files with 518 additions and 1,163 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -62,7 +62,10 @@ jobs:
                 rm package-lock.json || true
                 echo "D: npm install $SDK_JS_PACKAGE_NAME@$VERSION_NAME --foreground-scripts"
                 npm install $SDK_JS_PACKAGE_NAME@$VERSION_NAME --foreground-scripts
+                npm build
                 npm version
+                pwd
+                ls -l
                 npm publish --foreground-scripts
                 echo ""
                 cd $currentDir

diff --git a/cohort_banking_initiator_js/package-lock.json b/cohort_banking_initiator_js/package-lock.json
diff --git a/cohort_banking_initiator_js/package.json b/cohort_banking_initiator_js/package.json
@@ -19,7 +19,7 @@
     "typescript": "^5.1.6"
   },
   "dependencies": {
-    "@kindredgroup/cohort_sdk_client": "^0.0.1",
+    "@kindredgroup/cohort_sdk_client": "0.2.12",
     "pg": "^8.11.3",
     "winston": "^3.10.0"
   }

diff --git a/cohort_banking_initiator_js/src/banking-app.ts b/cohort_banking_initiator_js/src/banking-app.ts
@@ -99,7 +99,7 @@ export class BankingApp {
             async () => {
                 const s = Date.now()
                 const newRequest = await this.createNewRequest(tx) as any
-                logger.info("%s", JSON.stringify(newRequest, null, 2))
+                logger.debug("%s", JSON.stringify(newRequest, null, 2))
                 const n = Date.now()
                 stateEnd = n - span_s
                 stateDuration = n - s

diff --git a/cohort_banking_initiator_js/src/logger.ts b/cohort_banking_initiator_js/src/logger.ts
@@ -7,9 +7,8 @@ const logger = createLogger({
         format.timestamp(),
         format.align(),
         format.splat(),
-        format.simple()
+        format.printf(({ timestamp, level, message }) => `${ timestamp } - ${ level }: ${ message }`)
     ),
-    // defaultMeta: { service: "cohort_banking_js" },
     transports: [
         new transports.Console()
     ],