[RHPAM-3528] Increase KieExecutorMDB threads in RHPAM image #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desmax74
force-pushed
the
RHPAM-3528-7.12.x-cr1
branch
3 times, most recently
from
fa634e5 to
1b1cc18
Compare
jakubschwan
reviewed
Mar 17, 2022
desmax74
force-pushed
the
RHPAM-3528-7.12.x-cr1
branch
3 times, most recently
from
fcedf64 to
234c7e2
Compare
spolti
added
release-7.12.1
needs-cherry-pick 🍒
desmax74
force-pushed
the
RHPAM-3528-7.12.x-cr1
branch
2 times, most recently
from
3dad021 to
68d51c5
Compare
spolti
reviewed
Mar 17, 2022
spolti
suggested changes
Mar 17, 2022
| mdbMaxSessionPassed := false | ||
| for _, env := range env.Servers[0].DeploymentConfigs[0].Spec.Template.Spec.Containers[0].Env { | ||
| if strings.HasPrefix(env.Name, "JBOSS_MDB") { | ||
| if env.Name != "JBOSS_MDB_MAX_SESSION" && env.Value == "40" { | ||
| if strings.HasPrefix(env.Name, "KIE_EXECUTOR_MDB") { |
There was a problem hiding this comment.
there is a better way to test env, e.g.:
assert.Equal(t, "auth", getEnvVariable(env.Console.DeploymentConfigs[0].Spec.Template.Spec.Containers[0], "APPFORMER_INFINISPAN_SASL_QOP"))
6e149e5 to
9c01d1e
Compare
jakubschwan
reviewed
Mar 17, 2022
desmax74
force-pushed
the
RHPAM-3528-7.12.x-cr1
branch
from
d462c81 to
20cb351
Compare
spolti
approved these changes
Mar 17, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desmax74, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jakubschwan
reviewed
Mar 17, 2022
Signed-off-by: desmax74 <[email protected]>
desmax74
force-pushed
the
RHPAM-3528-7.12.x-cr1
branch
from
2837a7c to
a0bd0e8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://issues.redhat.com/browse/RHPAM-3528
Signed-off-by: desmax74 [email protected]