Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, use GitHub Actions #9

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Conversation

a-lavis
Copy link
Contributor

@a-lavis a-lavis commented Jan 28, 2024

What

  1. Removes .ruby_version
  2. Removes appraisals.
  3. Removes CircleCI config.
  4. Update gems.
  5. Add debug and irb gems to :development group in Gemfile.
  6. Add GitHub actions.

Why

  1. We can set our ruby version using rbenv on local and GitHub actions on CI.
  2. we can test multiple versions using rbenv on local and GitHub actions on CI.
  3. This a public repo and the testing setup is simple, might as well just use GitHub actions.
  4. Staying up to date is good!
  5. These gems are useful for debugging - they aren't required and they are built into Ruby, but by adding them to the Gemfile we can use the latest versions of these tools.
  6. We can ensure that tests are passing for a PR before merging it.

Overall, this will make it easier to contribute to mail-x_smtpapi.

@a-lavis a-lavis marked this pull request as ready for review January 29, 2024 14:14
on:
push:
branches:
- master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the main branch to main while we're here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and update it in main.yml, but I don't think I can update the default GitHub branch without admin privileges. Would you be able to do that for me?

- '3.0.6'
- '3.1.4'
- '3.2.2'
- '3.3.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make these minor versions. Do we really need to test < 3.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured we might as well since the tests pass. We could keep testing < 3.2 as long as the ruby versions are supported and the tests pass. But I'm also happy to remove them if you'd prefer!

.github/workflows/main.yml Show resolved Hide resolved
@a-lavis
Copy link
Contributor Author

a-lavis commented Jan 30, 2024

@amancevice do you know how to get rid of the CircleCI Pipeline CI error? Is there a way we can get CircleCI to stop watching this repo?

@amancevice
Copy link
Contributor

@a-lavis I'm just gonna merge it and take care of the branch and circle issues after.

@amancevice amancevice merged commit 1a0d40b into master Jan 30, 2024
2 of 3 checks passed
@amancevice amancevice deleted the update-and-CI branch January 30, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants