-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, use GitHub Actions #9
Conversation
.github/workflows/main.yml
Outdated
on: | ||
push: | ||
branches: | ||
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the main branch to main
while we're here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and update it in main.yml
, but I don't think I can update the default GitHub branch without admin privileges. Would you be able to do that for me?
.github/workflows/main.yml
Outdated
- '3.0.6' | ||
- '3.1.4' | ||
- '3.2.2' | ||
- '3.3.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make these minor versions. Do we really need to test < 3.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured we might as well since the tests pass. We could keep testing < 3.2 as long as the ruby versions are supported and the tests pass. But I'm also happy to remove them if you'd prefer!
@amancevice do you know how to get rid of the CircleCI Pipeline CI error? Is there a way we can get CircleCI to stop watching this repo? |
@a-lavis I'm just gonna merge it and take care of the branch and circle issues after. |
What
.ruby_version
debug
andirb
gems to:development
group inGemfile
.Why
rbenv
on local and GitHub actions on CI.rbenv
on local and GitHub actions on CI.Gemfile
we can use the latest versions of these tools.Overall, this will make it easier to contribute to
mail-x_smtpapi
.