PM-43048 Review adjustments

kialo · Oct 20, 2023 · 31a3655 · 31a3655
1 parent 4bb8063
commit 31a3655
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,12 +1,11 @@
 ### v1.0.24 (Build - 2023101801)
 
-* Reintroduce discussionurl
-* Do not create new deployment ids per activity
+* Minor internal improvements.
 
 ### v1.0.23 (Build - 2023092701)
 
 * Send plugin version number to Kialo.
-* Fix help center link
+* Fix help center link.
 
 ### v1.0.22 (Build - 2023091401)
 

diff --git a/classes/lti_flow.php b/classes/lti_flow.php
@@ -145,15 +145,15 @@ public static function init_resource_link(
 
         return self::build_platform_originating_launch(
             LtiMessageInterface::LTI_MESSAGE_TYPE_RESOURCE_LINK_REQUEST,
-            $discussionurl, // Unused, as the final destination URL will be decided by our backend.
+            $discussionurl,
             $deploymentid,
             $moodleuserid,
             $courseid,
             $roles,
             [
                 // The resource link claim is required in the spec, but we don't use it
                 // https://www.imsglobal.org/spec/lti/v1p3#resource-link-claim.
-                new ResourceLinkClaim('resource-link-' . $deploymentid, '', ''),
+                new ResourceLinkClaim('resource-link-' . $coursemoduleid, '', ''),
             ],
         );
     }