Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Carousel in the Events Psge Events #271

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Ajayendra2705
Copy link
Contributor

No description provided.

Copy link
Contributor

@destryptor destryptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check discord once for the details of the changes I feel are required. Functionality is fine otherwise.

Copy link
Contributor

@destryptor destryptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes that I suggested in the meet day before yesterday ASAP. For your ease, these are what I mentioned:

  1. Change the color of the arrows to the shade of the red we use in the website, the HEX code can be found in the root css file, you can also use custom property mentioned there directly.
  2. Increase the padding of the arrows a bit, and the black hover color seems a bit out of place. Change it to perhaps a less opaque version of the current one. You can also do what you think is correct. I'll leave this to your imagination.
  3. Add border radius to the same button div, the sharp corners don't sit well with the round corners of the image div.
  4. The pagination radio buttons color is still blue. Change it to red or something.
  5. Rest is upto you, as a frontend member, you can make changes which you feel will look better.

PS: I see that you have used an external script for the carousel, though it was expected that the thing would be implemented from scratch. Anyways, leave it for now since it's working. Keep it in mind from next time.
Expecting the changes to be done by EOD.

… some ideas to make it look better I will add it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants