Add comprehensive form validation for submission form #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsAnkan
reviewed
Dec 1, 2024
There was a problem hiding this comment.
Please ignore it. maybe ye jab setup mein issue aarha tha toh gpt ke suggestions pe add kra hoga
|
Looks fine to me, but yeah, it doesn't make sense to add ejs to the list of dependencies if it's not being used. Please remove it since we shouldn't be changing package.json just like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add client side form validation to the content submission form. Each form field is now validated for completeness and correctness, covering edge cases and providing clear feedback messages.
Enhancements -
Email Validation: Validates format against common patterns, covering edge cases to prevent invalid email entries.
Name Validation: Ensures name is between 3 and 25 characters, containing only letters and spaces.
Member Status: Ensures the user selects whether they are a member or not.
Content Type: Ensures the user selects a type of content, preventing empty submissions.
Drive Link Validation: Validates the link structure to ensure it is a valid Google Drive URL.
Proof of Ownership (Optional URL): If provided, checks that the proof field contains a valid URL.
Social Media Handle (Optional): Validates either an @username format or a URL link if a social handle is provided.