Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Gov portal submissions #265

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

Conversation

uday-kalyan-s
Copy link
Contributor

@uday-kalyan-s uday-kalyan-s commented Oct 30, 2024

hello guys. i finished the gov portal submissions stuff. here is a draft PR for reviews.

progress:

  • added gov portal template
  • added route to acces template (gov-portal/submission-management)
  • added route to delete template (post at the same route)
  • added link in gov portal home page
  • added link in gov portal nav

@uday-kalyan-s uday-kalyan-s marked this pull request as draft October 30, 2024 14:48
@uday-kalyan-s uday-kalyan-s self-assigned this Oct 30, 2024
@uday-kalyan-s uday-kalyan-s added easy stuff Good for newcomers, or if you want to do something quick feature A new feature instead labels Oct 30, 2024
@uday-kalyan-s uday-kalyan-s added this to the Governor Portal (pt. 3) milestone Oct 30, 2024
@Goose-Of-War
Copy link
Member

You were going to add modals or something too right?

Copy link
Member

@Goose-Of-War Goose-Of-War left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible try paginating it (as in displaying only the first 10 results or so, and then the rest in a next/prev set)

Save the data in the template itself as JS and change up stuff I guess

@uday-kalyan-s
Copy link
Contributor Author

You were going to add modals or something too right?

@Goose-Of-War this is the popup modal u were referring to right, to clarify, on click it would sort of magnify to the page and show the artwork and stuff. ig i can do implement that.

If possible try paginating it (as in displaying only the first 10 results or so, and then the rest in a next/prev set)
Save the data in the template itself as JS and change up stuff I guess

sureee but like one of the points of paginating it is so u only send enough info to the client right. i mean i can implement the pagination part in client side itself i don't mind but should I directly do it in the server side. also the artwork and amv page could use pagination so i thought if anyone is implementing it, it would be done on a whole

@uday-kalyan-s
Copy link
Contributor Author

but in the artworks page its probably better to implement pagination sort of dynamically. when the user scrolls to a certain point, it is fetched

@Goose-Of-War
Copy link
Member

but in the artworks page its probably better to implement pagination sort of dynamically. when the user scrolls to a certain point, it is fetched

We currently don't have an API model or something for fetched. So if you want to do that, it'll be more like you are just storing the addresses. Also, the three column CSS also has some special requirements; you can't fit any sets of images, unless you want the page to resize often

@Goose-Of-War
Copy link
Member

@Goose-Of-War this is the popup modal u were referring to right, to clarify, on click it would sort of magnify to the page and show the artwork and stuff. ig i can do implement that.

It's more of a "if we need it only" kinda thing. You don't necessarily need it if the current UI (which is shit, hopefully the migrated one is better) is what you are going to use.

@uday-kalyan-s
Copy link
Contributor Author

I think it would be better to implement it in the newer UI tbh.

@uday-kalyan-s
Copy link
Contributor Author

I can do the pagination bit for the current site though

@uday-kalyan-s uday-kalyan-s marked this pull request as ready for review December 2, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy stuff Good for newcomers, or if you want to do something quick feature A new feature instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants