errors in RDB test-cases are fixed! (solving the issue #54) #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjdmeest
reviewed
Nov 22, 2021
There was a problem hiding this comment.
I think we originally had the impression that the resultset of a d2rq query could be returned as either a CSV or an XML, kind of like how SQL resultsets can be returned as a table or an XML file. However, I get how that doesn't really make sense, looking at how R2RML specifies rr:column, or the example as given at https://rml.io/docs/rml/data-retrieval/ (that also doesn't specify a reference formulation). I have the feeling we can drop that requirement, so I'm fine with this change :). But maybe @pheyvaer or @andimou can verify my reasoning?
|
@andimou what do you think? I'll merge this one next week after the KGC meeting if no comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.