New features proposed in issues implemented in the ontology #136

anaigmo · 2024-07-08T14:15:14Z

This PR includes new features in the ontology and related documentation, solving the following issues:

#120: Should DatatypeMap be defined as a TermMap?
#72 add rml:UnsafeIRI and rml:UnsafeURI to ontology, shapes and spec
#50 add rml:URI to ontology, shapes and spec
#30 add rml:baseIRI property to ontology, shapes and spec
#51 Move rml:Strategyand rml:strategy to RML-CC
#51 Inconsistency due to rdfs:domain of rml:logicalTarget and its use on rml:LanguageMap

pmaria

Thanks @anaigmo. Some minor comments

pmaria · 2024-07-09T05:36:30Z

ontology/documentation/ontology.ttl

@@ -193,7 +200,12 @@

 ###  http://w3id.org/rml/logicalTarget
 <http://w3id.org/rml/logicalTarget> rdf:type owl:ObjectProperty ;
-                                    rdfs:domain <http://w3id.org/rml/TermMap> ;
+                                    rdfs:domain [ rdf:type owl:Class ;
+                                                  owl:unionOf ( <http://w3id.org/rml/DatatypeMap>


<http://w3id.org/rml/DatatypeMap> can be removed

pmaria · 2024-07-09T05:37:51Z

ontology/documentation/ontology.ttl

@@ -496,6 +496,27 @@
                                 rdfs:label "Triples Map" .


+###  http://w3id.org/rml/URI
+<http://w3id.org/rml/URI> rdf:type owl:Class ;
+                          rdfs:comment "Denotes an URI, used with termType."@en ;


Suggested change

rdfs:comment "Denotes an URI, used with termType."@en ;

rdfs:comment "Denotes a URI, used with termType."@en ;

pmaria · 2024-07-09T05:38:58Z

ontology/rml-core.owl

-               rdfs:domain :TermMap ;
+       rdfs:domain [ rdf:type owl:Class ;
+                     owl:unionOf ( :TermMap
+                                   :DatatypeMap


:DatatypeMap can be removed

pmaria · 2024-07-09T05:39:49Z

ontology/rml-core.owl

+
+###  http://w3id.org/rml/URI
+:URI rdf:type owl:Class ;
+     rdfs:comment "Denotes an URI, used with termType."@en ;


Suggested change

rdfs:comment "Denotes an URI, used with termType."@en ;

rdfs:comment "Denotes a URI, used with termType."@en ;

pmaria · 2024-07-09T06:48:01Z

ontology/rml-core.owl

+###  http://w3id.org/rml/baseIRI
+:baseIRI rdf:type owl:ObjectProperty ;
+       rdfs:domain :TriplesMap ;
+       rdfs:comment "Indicates the base IRI of the RDF graph to be created."@en ;


Suggested change

rdfs:comment "Indicates the base IRI of the RDF graph to be created."@en ;

rdfs:comment "Indicates the base IRI of the RDF graph to be created with this triples map."@en ;

anaigmo · 2024-07-10T08:31:20Z

Updated files according to @pmaria 's review in last commit

dachafra · 2024-07-11T06:06:36Z

ok, let's wait until his final approval to merge it (@pmaria), thanks @anaigmo

pmaria

Just one minor comment on the definition of baseIRI. Once that is fixed we can merge it

pmaria · 2024-07-11T06:50:27Z

ontology/rml-core.owl

+###  http://w3id.org/rml/baseIRI
+:baseIRI rdf:type owl:ObjectProperty ;
+       rdfs:domain :TriplesMap ;
+       rdfs:comment "Indicates the base IRI of the RDF graph to be created within a triples map."@en ;


Within is a bit odd, with is better since it indicates that this triples map is used to generate a graph with.

Suggested change

rdfs:comment "Indicates the base IRI of the RDF graph to be created within a triples map."@en ;

rdfs:comment "Indicates the base IRI of the RDF graph to be created with a triples map."@en ;

anaigmo · 2024-07-11T09:24:11Z

Oki, now that definition is fixed :)

chrdebru · 2024-08-16T12:09:21Z

I looked at @anaigmo and @pmaria's work in the spec and shapes. I just want to confirm, unlike @dachafra's proposal of "pushing it further", rml:baseIRI's domain is triples maps, right?

Also, do we keep base IRIs as input in the configuration (overwritten by rml:baseIRI) when present, or do we assume that baseIRIs must be provided. The former is more flexible. The latter will require us to change all the test cases and examples in our specifications. Happy to work on rml:baseIRI test cases in the case of the former (testing failures, testing overwrites, ...).

pmaria · 2024-08-17T02:33:11Z

I looked at @anaigmo and @pmaria's work in the spec and shapes. I just want to confirm, unlike @dachafra's proposal of "pushing it further", rml:baseIRI's domain is triples maps, right?

Yest that is how I understood it, and how it is defined in the ontology now.

Also, do we keep base IRIs as input in the configuration (overwritten by rml:baseIRI) when present, or do we assume that baseIRIs must be provided. The former is more flexible. The latter will require us to change all the test cases and examples in our specifications. Happy to work on rml:baseIRI test cases in the case of the former (testing failures, testing overwrites, ...).

Yes, the former would be my preference as well. I think we should also explicitly define a default in the spec for if no baseIRI is provided via configuration.

anaigmo added 8 commits July 8, 2024 15:07

strategy moved back to rml-cc module

f629bb1

Added subclasses of term types: URI, Unsafe URI and Unsafe IRI

f785d49

datatype map as term map, instead of expression map

06c567e

base IRI added

cc8884b

logical target domain extended, minor fixes in definitions

f1154b0

diagram updated with new term types, base iri, datatype map as term map

2915d1e

fixing uris for new classes

6e9d1b4

documentation updated

955578b

dachafra requested review from pmaria and DylanVanAssche July 8, 2024 18:42

pmaria requested changes Jul 9, 2024

View reviewed changes

pmaria reviewed Jul 9, 2024

View reviewed changes

implementing changes from review of PR

7f29c0e

pmaria requested changes Jul 11, 2024

View reviewed changes

baseIRI def fixed

9ef0b05

pmaria approved these changes Jul 11, 2024

View reviewed changes

pmaria merged commit 4fd1780 into kg-construct:main Jul 11, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New features proposed in issues implemented in the ontology #136

New features proposed in issues implemented in the ontology #136

anaigmo commented Jul 8, 2024

pmaria left a comment

pmaria Jul 9, 2024

pmaria Jul 9, 2024

pmaria Jul 9, 2024

pmaria Jul 9, 2024

pmaria Jul 9, 2024

anaigmo commented Jul 10, 2024

dachafra commented Jul 11, 2024

pmaria left a comment

pmaria Jul 11, 2024

anaigmo commented Jul 11, 2024

chrdebru commented Aug 16, 2024 •

edited

Loading

pmaria commented Aug 17, 2024

	rdfs:comment "Denotes an URI, used with termType."@en ;
	rdfs:comment "Denotes a URI, used with termType."@en ;

	rdfs:comment "Indicates the base IRI of the RDF graph to be created."@en ;
	rdfs:comment "Indicates the base IRI of the RDF graph to be created with this triples map."@en ;

New features proposed in issues implemented in the ontology #136

New features proposed in issues implemented in the ontology #136

Conversation

anaigmo commented Jul 8, 2024

pmaria left a comment

Choose a reason for hiding this comment

pmaria Jul 9, 2024

Choose a reason for hiding this comment

pmaria Jul 9, 2024

Choose a reason for hiding this comment

pmaria Jul 9, 2024

Choose a reason for hiding this comment

pmaria Jul 9, 2024

Choose a reason for hiding this comment

pmaria Jul 9, 2024

Choose a reason for hiding this comment

anaigmo commented Jul 10, 2024

dachafra commented Jul 11, 2024

pmaria left a comment

Choose a reason for hiding this comment

pmaria Jul 11, 2024

Choose a reason for hiding this comment

anaigmo commented Jul 11, 2024

chrdebru commented Aug 16, 2024 • edited Loading

pmaria commented Aug 17, 2024

chrdebru commented Aug 16, 2024 •

edited

Loading