Detect IDevID/IAK template from certificates #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit retest-failed |
stefanberger
reviewed
Jan 3, 2024
keylime-agent.conf
Outdated
| @@ -228,19 +228,21 @@ tpm_signing_alg = "rsassa" | |||
| ek_handle = "generate" | |||
|
|
|||
| # Enable IDevID and IAK usage and set their algorithms. | |||
| # Choosing a template will override the name and asymmetric algorithm choices. | |||
| # By default the template will be detected automatically from the certificates. This will happen in iak_idevid_template is left empty or set as "default" or "detect". | |||
There was a problem hiding this comment.
Thanks, fixed
stefanberger
approved these changes
Jan 3, 2024
Isaac-Matthews
force-pushed
the
detect_idevid_template
branch
from
0406adf
to
1c20f8c
Compare
|
Works with "detect" now. Very cool! |
|
@Isaac-Matthews Thank you for implementing this! Could you please rebase? |
Signed-off-by: Isaac Matthews <[email protected]>
Isaac-Matthews
force-pushed
the
detect_idevid_template
branch
from
1c20f8c
to
96725bc
Compare
No problem. Done! |
Codecov ReportAttention:
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ansasaki
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the requested auto-detect functionality for the agent. The new default setting for the IDevID and IAK templates will be
detect, and with that set the agent will detect what template has been used from the imported certificates. This can still be overridden by users that want to specify the template or algorithm but likely should be left as default for the majority of users.The certs are now imported first, and the key regeneration is delayed until after, with the key comparison against the certs performed during key regeneration.