Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Update styles.css to comply with PatternFly v5 syntax changes #594

Closed
wants to merge 2 commits into from
Closed

Fix: Update styles.css to comply with PatternFly v5 syntax changes #594

wants to merge 2 commits into from

Conversation

alaa60
Copy link

@alaa60 alaa60 commented Sep 3, 2024

Fix #593

@alaa60 alaa60 force-pushed the update-patternfly-syntax branch 2 times, most recently from 199519f to 3fc62d3 Compare September 3, 2024 14:29
edewit
edewit suggested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@edewit edewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll have to target main instead of latest

jonkoops
jonkoops suggested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the version changes in this PR. If you want to test things locally you can pass -Pnightly to Maven instead.

@mposolda
Copy link
Contributor

@alaa60 Could you please re-send the PR to the main branch instead of latest branch as mentioned in the previous comments? See warning at https://github.com/keycloak/keycloak-quickstarts/blob/latest/CONTRIBUTING.md#contributing-to-keycloak-quickstarts

@mposolda mposolda closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonkoops jonkoops jonkoops requested changes

@edewit edewit edewit requested changes

@ssilvert ssilvert Awaiting requested review from ssilvert

@agagancarczyk agagancarczyk Awaiting requested review from agagancarczyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update required in styles.css for PatternFly 5 compatibility
4 participants
@alaa60 @mposolda @edewit @jonkoops